-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeneSplicer: improve argument processing #689
GeneSplicer: improve argument processing #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nuno-agostinho,
Thank you very much for this change, tested while running on docker v4.27.1
Just some changes.
Thank you
Ola
Hi @olaaustine, I updated the PR with your suggestions. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nuno-agostinho,
Thank you for this change.
Tested on Docker and on the cluster.
LGTM!.
Waiting for this before merging.
Thank you
Merged into release/112 and main. |
Improves on Ensembl/ensembl-vep#1599
Changelog
genesplicer
command instead of a pathgenesplicer
is exported in the$PATH
variable (like in VEP Docker)genesplicer
is internally obtained viawhich
binary
withgenesplicer
as defaulttraining
with no defaultTesting
If
genesplicer
is exported in the$PATH
variable, like in VEP Docker/Singularity (Ensembl/ensembl-vep#1599), there is no need to explicitly call it:This means that the only mandatory argument now is the training data.