Skip to content

Commit

Permalink
Vep results table (#1147)
Browse files Browse the repository at this point in the history
Also:
- Moved the VariantColor component from genome browser directory into the shared directory
  (and renamed it to remove u from colour)
- Created a shared VariantConsequence component that combines the string label of a variant consequence
   with a corresponding colour.
- Updated the ViewInAppPopup component such that:
   a) it uses a button element instead of a span element to wrap around the anchor;
   b) it sets blue colour to children's text
  • Loading branch information
azangru authored Jun 25, 2024
1 parent bd7ef12 commit 711c406
Show file tree
Hide file tree
Showing 23 changed files with 5,542 additions and 43 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import type { Pick2 } from 'ts-multipick';

import VariantColour from 'src/content/app/genome-browser/components/drawer/components/variant-colour/VariantColour';
import VariantColour from 'src/shared/components/variant-color/VariantColor';

import type { Variant } from 'src/shared/types/variation-api/variant';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@
padding: 5px 20px var(--global-padding-bottom) 140px;
}

.exampleLinkText {
cursor: pointer;
color: var(--color-blue);
position: relative;
}

.pointerBox {
padding: 6px 12px;
background: var(--color-black);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,7 @@ type ExampleLinkPopupProps = {
const ExampleLinkWithPopup = (props: ExampleLinkPopupProps) => {
return (
<div className={styles.exampleLink}>
<ViewInAppPopup links={props.links}>
<span className={styles.exampleLinkText}>{props.children}</span>
</ViewInAppPopup>
<ViewInAppPopup links={props.links}>{props.children}</ViewInAppPopup>
</div>
);
};
Expand Down
1 change: 1 addition & 0 deletions src/content/app/tools/vep/VepPageContent.module.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.grid {
display: grid;
grid-template-rows: auto auto 1fr;
height: 100%;
}
11 changes: 3 additions & 8 deletions src/content/app/tools/vep/VepPageContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import VepAppBar from './components/vep-app-bar/VepAppBar';
import VepTopBar from './components/vep-top-bar/VepTopBar';
import VepForm from './views/vep-form/VepForm';
import VepSpeciesSelector from './views/vep-species-selector/VepSpeciesSelector';
import VepSubmissionResults from './views/vep-submission-results/VepSubmissionResults';
import { NotFoundErrorScreen } from 'src/shared/components/error-screen';

import styles from './VepPageContent.module.css';
Expand All @@ -38,20 +39,14 @@ const Main = () => {
return (
<Routes>
<Route index={true} element={<VepForm />} />
<Route
path="species-selector"
element={<VepSpeciesSelector />}
/>
<Route path="species-selector" element={<VepSpeciesSelector />} />
<Route
path="unviewed-submissions"
element={<div>List of unviewed submissions</div>}
/>
<Route path="submissions">
<Route index={true} element={<div>List of viewed submissions</div>} />
<Route
path=":submissionId"
element={<div>Results of a single VEP analysis</div>}
/>
<Route path=":submissionId" element={<VepSubmissionResults />} />
</Route>
<Route path="*" element={<NotFoundErrorScreen />} />
</Routes>
Expand Down
Loading

0 comments on commit 711c406

Please sign in to comment.