Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed check for genebuild.version=genebuild.start_date #616

Open
wants to merge 1 commit into
base: release/114
Choose a base branch
from
Open

Removed check for genebuild.version=genebuild.start_date #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions lib/Bio/EnsEMBL/DataCheck/Checks/MetaKeyFormat.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,7 @@ sub tests {
skip "No sample.transcript_text defined", 1 unless defined $transcript_text;
isnt($transcript_text, 'ensembl_transcript', $desc);
}

# Check for 'external' geneset names that are the same as the Ensembl name
my $gb_version = $mca->single_value_by_key('genebuild.version');
my $gb_start_date = $mca->single_value_by_key('genebuild.start_date');
SKIP: {
my $desc = 'Value for genebuild.version is not copied from genebuild.start_date';
skip "No genebuild.version defined", 1 unless defined $gb_version;
skip "No genebuild.start_date defined", 1 unless defined $gb_start_date;
isnt($gb_version, $gb_start_date, $desc);
}


# Characters with accents, umlauts, etc. cause problems for compara
{
my $species_id = $self->dba->species_id;
Expand Down