-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow https download and GITHUB_TOKEN in VEP Install #1805
Allow https download and GITHUB_TOKEN in VEP Install #1805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nakib103, just minor suggestions. Thank you!
Hi @olaaustine , thanks for the good suggestions, have updated them all. Also, updated the usage text in public plugins doc - https://github.com/Ensembl/public-plugins/pull/844/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pushed to main and release/114 |
ENSVAR-6431
--USE_HTTPS_PROTO
which would allow using https protocol to download cache and FASTA file instead of FTP. Useful in network where FTP port is blocked.--GITHUBTOKEN
or--GITHUB_TOKEN
which would allow providing GITHUB token to query GitHub API using curl and allow increase in rate limit.Public doc update - Ensembl/public-plugins#844