Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing static content for 114 #848

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

EreboPSilva
Copy link
Member

for genebuild content:

addign some new pages, editing others, and updating the strains page for rodents

We havent changed anything from the comparative analysis section on the mouse strains file, and we'd like to check with compara if that's still current and ok, so mentioning here @ens-sb and @twalsh-ebi so that they can offer their view on the topic.

I'd like to also wait for them to approve to merge anything, unless time is of the esence.

addign some new pages, editing others, and updating the strains page for
rodents
@twalsh-ebi
Copy link
Contributor

Hi @EreboPSilva .. I think the text on comparative data in Mus_musculus_strains.inc is in need of an update.

Any thoughts (@EreboPSilva and @kamaldodiya) on whether it would be better to suggest a change in this PR or submit a separate pull request?

As needed for the displaying of the data
@EreboPSilva EreboPSilva force-pushed the genebuild_static_content branch from cac47ed to 274a42d Compare February 11, 2025 13:34
Via misuse of git push --force, accidentally overwrote the changes
suggested by @twalsh-ebi and approved by @ens-sb and myself.
I replicated the suggestion and [hopefully] fixed the issue.
@EreboPSilva EreboPSilva force-pushed the genebuild_static_content branch from 7f28fa6 to cb8052b Compare February 11, 2025 13:44
reference-quality genomes from the The Mouse Genomes Project with <i>Mus
musculus</i>, <i>Rattus norvegicus</i> and an additional three <i>Mus</i>
species&colon; <i>Mus caroli</i>, <i>Mus pahari</i> and <i>Mus
spicilegus</i>. Additionally, we have computed a LastZ alignment of <i>Mus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final suggestion, to avoid repetition:

Suggested change
spicilegus</i>. Additionally, we have computed a LastZ alignment of <i>Mus
spicilegus</i>. Furthermore, we have computed a LastZ alignment of <i>Mus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants