Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify which values are optional. #6346

Merged
merged 9 commits into from
Jan 6, 2025
Merged

Clarify which values are optional. #6346

merged 9 commits into from
Jan 6, 2025

Conversation

sonotley
Copy link
Contributor

Clarify which values are optional.

Explain that PEM will still create agent users even when pem-agent-user is provided.

@sonotley
Clarify which values are optional.
fe03905 
Explain that PEM will still create agent users even when pem-agent-user is provided.
@sonotley sonotley added the deploy Add this label to a PR and it will automatically be deployed to netlify label Dec 12, 2024
@sonotley sonotley requested a review from a team as a code owner December 12, 2024 11:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-6346--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-6346-pem-register-agent-tweaks December 12, 2024 11:45 Inactive
@github-actions github-actions bot temporarily deployed to pr-6346-pem-register-agent-tweaks December 12, 2024 11:55 Inactive
@github-actions github-actions bot temporarily deployed to pr-6346-pem-register-agent-tweaks December 12, 2024 16:08 Inactive
@github-actions github-actions bot temporarily deployed to pr-6346-pem-register-agent-tweaks December 16, 2024 13:28 Inactive
@sonotley
Copy link
Contributor Author

Most changes are on this page https://deploy-preview-6346--edb-docs-staging.netlify.app/docs/pem/latest/registering_agent/

@github-actions github-actions bot temporarily deployed to pr-6346-pem-register-agent-tweaks December 16, 2024 13:40 Inactive
nidhibhammar
nidhibhammar reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@nidhibhammar nidhibhammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some suggestions. Accept/Reject as required.

@sonotley
Copy link
Contributor Author

All comments addressed

@nidhibhammar
Copy link
Contributor

@sonotley, is this good to merge and publish now?

@nidhibhammar nidhibhammar merged commit 54567ea into develop Jan 6, 2025
3 checks passed
@nidhibhammar nidhibhammar deleted the pem/register-agent-tweaks branch January 6, 2025 09:46
@djw-m djw-m mentioned this pull request Jan 7, 2025
Merged
@josh-heyer josh-heyer mentioned this pull request Jan 9, 2025
Merged
ebgitelman added a commit that referenced this pull request Jan 10, 2025
@ebgitelman
Edits to Clarify which values are optional. #6346
75cad88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbjunwang edbjunwang edbjunwang left review comments

@nidhibhammar nidhibhammar nidhibhammar approved these changes

@asheshv asheshv Awaiting requested review from asheshv

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sonotley @nidhibhammar @asheshv @edbjunwang