add flag to surpress apple's -bundle flag #2028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed by Tim's solution using an existing flag in EnzymeAD/rust#150 |
auto-merge was automatically disabled
August 2, 2024 20:29
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with another apple user. Apparently #1683 wasn't wrong after all, it just needs to be limited to apple and not run on Linux. Part of EnzymeAD/rust#145 and the previous EnzymeAD/rust#73 attempt.
cc @tgymnich, do you think that's something that can just be turned on by default for all Apple cases, or is it only good for the Rust Apple case, where we want to link libLLVMEnzyme-17.dylib in?