This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 260
Add contribution guideline CONTRIBUTING.md
#352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made a start on the doc Signed-off-by: Denis Phoenix <[email protected]>
- Completed the main body of the doc - Added legal blurb (very slim so far) - Passing to Luke to add coding style and anything else Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Added coding style and documentation style Signed-off-by: Luke Bermingham <[email protected]>
- Polished the doc and added final touches, ready for PR. Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
- Added reference to the contribution guide Signed-off-by: Denis Phoenix <[email protected]>
CONTRIBUTING.md
lukehb
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor edits then good to ship!
- Addressed Luke's notes in the PR. Signed-off-by: Denis Phoenix <[email protected]>
- Addressed Luke's comments in the PR. Signed-off-by: Denis Phoenix <[email protected]>
- Added a thank you line to the new contributing header. Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Luke Bermingham <[email protected]>
lukehb
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Description:
This PR adds a contribution guideline to the repository.
Issue link:
Resolves #230