Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add contribution guideline CONTRIBUTING.md #352

Merged
merged 14 commits into from
Aug 24, 2023
Merged

Add contribution guideline CONTRIBUTING.md #352

merged 14 commits into from
Aug 24, 2023

Conversation

DenisTensorWorks
Copy link
Collaborator

@DenisTensorWorks DenisTensorWorks commented Aug 24, 2023

Relevant components:

  • Documentation

Description:

This PR adds a contribution guideline to the repository.

Issue link:

Resolves #230

DenisTensorWorks and others added 10 commits August 22, 2023 16:43
- Made a start on the doc

Signed-off-by: Denis Phoenix <[email protected]>
- Completed the main body of the doc
- Added legal blurb (very slim so far)
- Passing to Luke to add coding style and anything else

Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
Added coding style and documentation style

Signed-off-by: Luke Bermingham <[email protected]>
- Polished the doc and added final touches, ready for PR.

Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Denis Phoenix <[email protected]>
- Added reference to the contribution guide

Signed-off-by: Denis Phoenix <[email protected]>
@DenisTensorWorks DenisTensorWorks changed the title Contributing md Add contribution guideline CONTRIBUTING.md Aug 24, 2023
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits then good to ship!

README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
DenisTensorWorks and others added 4 commits August 24, 2023 12:07
- Addressed Luke's notes in the PR.

Signed-off-by: Denis Phoenix <[email protected]>
- Addressed Luke's comments in the PR.

Signed-off-by: Denis Phoenix <[email protected]>
- Added a thank you line to the new contributing header.

Signed-off-by: Denis Phoenix <[email protected]>
Signed-off-by: Luke Bermingham <[email protected]>
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukehb lukehb merged commit 21abd38 into master Aug 24, 2023
@lukehb lukehb deleted the contributing-md branch August 24, 2023 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

add "Contributing.md" file to repo
2 participants