Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

chore: remove auto-assigned prop #434

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chore: remove auto-assigned prop #434

merged 1 commit into from
Nov 21, 2023

Conversation

evenstensberg
Copy link
Contributor

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Removes prop that is automatically assigned in webpack

Solution

N/A

Documentation

N/A

Test Plan and Compatibility

N/A

Or better yet, link to the unit tests that accompany this PR.

Signed-off-by: Even Stensberg <[email protected]>
@lukehb
Copy link
Contributor

lukehb commented Nov 20, 2023

Can you explain a little more the purpose of this PR?

Are you saying Webpack will automatically use the /dist directory and therefore we don't need to explicitly set it? If so, may you please provide a link to the official documentation?

@evenstensberg
Copy link
Contributor Author

Yes. Webpack will automatically output to dist. https://dev.to/yadhus/what-is-output-webpack-5-cho#what-is-output

@lukehb lukehb merged commit 7eba788 into EpicGames:master Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants