Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Fixing handling of StreamerId in the initial config settings. #438

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fixing handling of StreamerId in the initial config settings. #438

merged 2 commits into from
Nov 22, 2023

Conversation

mcottontensor
Copy link
Contributor

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

As described in #436 setting the StreamerId in the initial config does not work. This is because if we try to set an option selection that isn't already in the list the selection is ignored, and additionally when we get the streamer list, this option list is thrown out and reset with the streamer ids.

Solution

  • The setOptionSettingValue now adds the selected value if it doesn't already exist in the list. Without this the selection does not happen.
  • handleStreamerListMessage now checks the existing selection and uses it as the default wantedStreamerId. It also now correctly checks whether we're allowing URL params before checking them for the StreamerId.

Fixes #436

Documentation

Test Plan and Compatibility

Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcottontensor mcottontensor merged commit a3b76a3 into EpicGames:master Nov 22, 2023
1 check passed
@mcottontensor mcottontensor deleted the player_config_streamerid branch November 22, 2023 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Frontend ignores the StreamerId set in the config.
2 participants