Fix available CPU count and idle time when SMT is turned off#4
Draft
hach-que wants to merge 1 commit into
Draft
Conversation
Author
|
There's still something wrong with this - the calculation in |
slonopotamus
reviewed
Jan 9, 2026
| num_cpus = count_bits(all_cpus_mask); | ||
| + if (is_smt_disabled) | ||
| + { | ||
| + num_cpus /= 2; |
There was a problem hiding this comment.
Is it correct? I am under the impression that the code assumes CPU actually has SMT, but what if it doesn't?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This halves the idle time and CPU count when
WINE_IS_SMT_DISABLEDis set to1, which should fix CPU calculations when the Unreal Build Accelerator is running on machines with SMT turned off.