Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ARM to docker image #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZuluPro
Copy link

@ZuluPro ZuluPro commented Jun 3, 2023

Added ARM build for Docker images.

Issue: #26

@EpicWink
Copy link
Owner

EpicWink commented Jun 5, 2023

As I say in the issue, I need a way to test the ARM image before I release it. Either include an automated test for the image, or include (a link to) instructions on how I can emulate ARM locally

Also, I think this is a duplicate of #24

@ZuluPro
Copy link
Author

ZuluPro commented Jun 5, 2023

Hi @EpicWink
I added the ARM archs to the matrix

@EpicWink
Copy link
Owner

EpicWink commented Jun 5, 2023

I mean image integration test (make sure the server runs, and pip can install a package), not image creation. There's currently no testing of the x86 image yet I just added integration tests

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (61168e6) 88.63% compared to head (93bee24) 88.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   88.63%   88.63%           
=======================================
  Files           3        3           
  Lines         651      651           
=======================================
  Hits          577      577           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EpicWink
Copy link
Owner

EpicWink commented Jun 6, 2023

I can't get CI to work: https://github.com/EpicWink/proxpi/actions/runs/5180236563

@EpicWink EpicWink mentioned this pull request Mar 18, 2024
@EpicWink
Copy link
Owner

Does #45 meet your needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants