Skip to content

Fix/typed notification preferences - #1037

Open
barry01-hash wants to merge 3 commits into
Epta-Node:mainfrom
barry01-hash:fix/typed-notification-preferences
Open

Fix/typed notification preferences#1037
barry01-hash wants to merge 3 commits into
Epta-Node:mainfrom
barry01-hash:fix/typed-notification-preferences

Conversation

@barry01-hash

@barry01-hash barry01-hash commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Closes #977

Summary

Type of Change

  • Bug fix
  • New feature
  • Contract change (logic, storage, or API)
  • Documentation update
  • Refactor / chore

Testing Done

  • cargo test passes
  • New tests added for changed behaviour
  • Manually verified on Testnet (if applicable)

Checklist

  • Changes are focused — one concern per PR
  • If a contract function was added or changed, the README API table is updated
  • No unresolved merge conflicts
  • No secrets or private keys committed

Related Issue

Closes #

- Add NotificationPreferences interface to indexer notification service
- Add PreferencesStore interface and getPreferences/setPreferences methods
- Add PostgresPreferencesStore and MemoryPreferencesStore implementations
- Add isNotificationEnabled helper to gate dispatch on user preferences
- Wire preferences check into dispatchEventNotification
- Add GET/PUT /api/notifications/preferences/:address routes
- Add 012_notification_preferences.sql migration
- Replace any types in frontend savePreferencesToBackend with typed payload
- Add getPreferencesFromBackend helper function
@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

@barry01-hash is attempting to deploy a commit to the Jaja's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@barry01-hash Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@devJaja

devJaja commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@barry01-hash

Resolve the conflicts please

@devJaja

devJaja commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@barry01-hash
Resolve the conflicts so i can merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: indexer notification getPreferences() returns Promise<any>

2 participants