Skip to content

feat(#65 P8): align remaining default value semantics (Limit.input) #74

Description

@yzxoi

问题

Default value semantics differ across layers.

已完成(PR #110 主要改动 + RCM timeout 字段)

  • Timeout: DEFAULT_TIMEOUT_SECS 常量已引入(crates/machine/src/model.rs:5),RCM 解析器和编译器已有 timeout 字段(ast.rs parser + compile.rs:362 应用)

仍待解决

Limit.input:

  • machine::Limit.input: Option<u64>: None means "same as context"
  • RCM compile: different resolution (only context → context=input; only input → input=context)
  • proto ModelSpec: optional — None = "no separate input limit"

Cost:

  • proto CostSpec is always optional — default behavior matches machine::Model

Proposed remaining fixes

  1. Limit.input: Document that None = same as context. Add a comment in proto LimitSpec clarifying the semantic.
  2. Add a consistency test that verifies default values match across layers.

Parent: #65

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions