Skip to content

Conversation

@monocongo
Copy link

This PR contains

  1. a setup.py file that allows for installation of this package into a Python (virtual) environment via the command:
$ python setup.py install

This setup file also includes a console script entry point named oidv4_toolkit
2. an updated requirements.txt file containing the results of pip freeze
3. various cleanups (formatting, removal of unused imports, etc.) for better PEP8 compliance
4. package can now be registered and uploaded to PyPI using method outlined in the initial comment for issue #52
5. valid .gitignore file

@monocongo monocongo changed the title seup.py with installation and console entry point setup.py with installation and console entry point Sep 2, 2019
…ich was causing a device error on Linux laptop when calling the download() function from another Python script
…ngs_for_numba

Updates for using the downloader outside of the CLI context
@keldrom
Copy link
Collaborator

keldrom commented Sep 16, 2019

There are changes that I don't approve (like changing the name of the classes)

@monocongo monocongo mentioned this pull request Sep 16, 2019
@monocongo
Copy link
Author

The package name should be something more specific than "modules", i.e., something that identifies the package so when you import modules from it then it's obvious what package you're importing from. At least that's how every other serious package does it anyway. For example, if you import OpenCV you use import cv2 or from requests you use from requests import *, etc.

dependabot bot and others added 13 commits March 24, 2021 19:34
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.25.8 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.25.8...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [numpy](https://github.com/numpy/numpy) from 1.17.1 to 1.22.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/HOWTO_RELEASE.rst)
- [Commits](numpy/numpy@v1.17.1...v1.22.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants