rag 기반 퀴즈 배틀 기능 제작#164
Merged
fixgramwork merged 6 commits intodevelopfrom Nov 23, 2025
Hidden character warning
The head ref may contain hidden characters: "CB-2-RAG-\uae30\ubc18-\ud034\uc988-\ubc30\ud2c0-\uae30\ub2a5-\uc81c\uc791"
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a real-time quiz battle system using WebSocket/STOMP with RAG-based question generation. The implementation includes room management, participant handling, real-time scoring, and automated question progression with timer-based controls.
Key Changes:
- WebSocket-based real-time quiz battle system with STOMP protocol
- RAG-based quiz generation through FastAPI integration (missing documentId implementation)
- Redis-backed real-time state management for participants, questions, and answers
- Automated question timer service with manual override capability
Reviewed changes
Copilot reviewed 36 out of 40 changed files in this pull request and generated 24 comments.
Show a summary per file
| File | Description |
|---|---|
QuizBattleService.java |
Core business logic for room/quiz management - missing documentId parameter support for RAG |
QuizBattleWebSocketController.java |
WebSocket endpoints for real-time quiz interactions |
QuizTimerService.java |
Scheduled timer service for automatic question progression - needs @PreDestroy |
QuizRoomRedisService.java |
Redis operations for real-time state management |
QuizBattleController.java |
REST API for room queries - has N+1 query issues |
WebSocketConfig.java |
WebSocket/STOMP configuration |
SecurityConfig.java |
Security bypass for WebSocket endpoints - security concern |
JWTFilter.java |
JWT filter updates to skip WebSocket - security concern |
QuizClient.java |
Feign client for FastAPI quiz generation |
| Domain Models | QuizRoom, QuizParticipant, QuizQuestion, QuizAnswer, QuizRanking entities |
| DTOs | Request/response/message DTOs - missing documentId fields |
| Tests | WebSocket integration tests and service unit tests |
QUIZ_BATTLE_GUIDE.md |
Comprehensive documentation for the feature |
Comments suppressed due to low confidence (1)
src/main/java/hello/cluebackend/presentation/websocket/quizbattle/QuizBattleWebSocketController.java:167
- Default toString(): UserDto inherits toString() from Object, and so is not suitable for printing.
customOAuth2User.getUserDTO(), request.getQuestionNumber(), roomCode);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/hello/cluebackend/presentation/api/quizbattle/QuizBattleController.java
Show resolved
Hide resolved
src/main/java/hello/cluebackend/domain/quizbattle/service/QuizBattleService.java
Show resolved
Hide resolved
src/main/java/hello/cluebackend/domain/quizbattle/service/QuizBattleService.java
Show resolved
Hide resolved
src/main/java/hello/cluebackend/domain/quizbattle/service/QuizBattleService.java
Show resolved
Hide resolved
src/main/java/hello/cluebackend/presentation/websocket/quizbattle/dto/CreateRoomRequest.java
Show resolved
Hide resolved
src/test/java/hello/cluebackend/domain/quizbattle/service/QuizBattleServiceTest.java
Show resolved
Hide resolved
src/test/java/hello/cluebackend/domain/quizbattle/service/QuizBattleServiceTest.java
Show resolved
Hide resolved
src/test/java/hello/cluebackend/domain/quizbattle/service/QuizBattleServiceTest.java
Show resolved
Hide resolved
...n/java/hello/cluebackend/presentation/websocket/quizbattle/dto/ParticipantJoinedMessage.java
Show resolved
Hide resolved
added 3 commits
November 22, 2025 23:49
Member
Author
|
완료 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 제목 규칙
[feat]
📑 개요
Socket을 활용한 quiz 배틀 API 제작
📌 체크리스트