Add Espresso Streamer #66

dailinsubjam · 2025-03-14T06:10:13Z

Closes https://app.asana.com/0/1209392461754458/1209619016749013/f
And we can leave the remaining TODOs and smokey test to https://app.asana.com/0/1209392461754458/1209619016749015/f

This PR:

Added the architecture of espresso streamer
Added a compilable version of caff node

This PR does not:

Do any test yet
Finish TODOs there
There are some place holders to be filled up relying on batcher's input

Key places to review:

init commit

push today's changes forget to add the file

log add caff node config fix config fix the bug...thanks... foget the error handling today's push remove FilterAndFind

added a Verify, but remember to debug commit today's change current change

foget to push the file again

dailinsubjam · 2025-03-20T17:11:58Z

op-node/rollup/types.go

+	// OverrideMessageExpiryTimeInterop is only used for testing purposes.
+	// It is used to override the protocol-defined interop message time expiry.
+	// DO NOT this read value directly. Use GetMessageExpiryTimeInterop instead.
+	OverrideMessageExpiryTimeInterop uint64 `json:"override_message_expiry_time_interop,omitempty"`


Weird, this argument is in celo-integration,but not in celo-tip, and it's being added when I'm doing a rebase on celo-integration-rebased

shenkeyao · 2025-03-20T19:56:24Z

op-batcher/batcher/driver.go

As discussed offline, we don't need the MultipleNodesClient.

I'll go to this in next PR. A comment from Jeb https://github.com/EspressoSystems/book/pull/37#discussion_r2006587177

op-batcher/batcher/espresso.go

op-node/node/config.go

shenkeyao · 2025-03-20T20:00:50Z

op-node/node/node.go

@@ -561,6 +561,10 @@ func (n *OpNode) Start(ctx context.Context) error {
 			return err
 		}
 	}
+	if n.cfg.CaffNodeConfig.IsCaffNode {
+		// Sishan TODO: deal with this in a better way and add error handling


Can do a very similar error handling like line 559 above.

It's a kind of different, I have to figure out how to do error handling for go routine.

op-node/rollup/derive/attributes_queue.go

shenkeyao · 2025-03-20T20:38:22Z

op-node/rollup/derive/espresso_streamer.go

+		case BatchUndecided:
+			remaining = append(remaining, s.messageWithHeight[i:]...)
+			s.messageWithHeight = remaining
+			return nil, false, io.EOF


Do we need this case? It looks like CheckBatchEspresso can't return BatchUndecided.

Here is a placeholder for the next task, it may be needed when I add more checks there.

Can you add a comment so we won't forget to remove or update this part?

op-node/rollup/derive/espresso_streamer.go

shenkeyao · 2025-03-20T21:01:39Z

op-node/rollup/derive/espresso_streamer.go

+		// We dont need to check majority here  because when we eventually go
+		// to fetch a block at a certain height,
+		// we will check that a quorum of nodes agree on the block at that height,
+		// which wouldn't be possible if we were somehow are given a height
+		// that wasn't finalized at all


As discussed offline, we won't use the majority rule.

I understand that after discussion we will use this rule right?

op-service/crypto/espresso_test.go

philippecamacho · 2025-03-25T19:31:23Z

op-service/crypto/espresso.go

+// from eth_sign.
+func Verify(data []byte, signature []byte, expected common.Address) error {
+	// Ensure the signature is 65 bytes long (r[32] || s[32] || v[1])
+	if len(signature) != 65 {


Why do we need to verify these conditions? Why not relying on standard signature verification as described in https://goethereumbook.org/signature-verify/ ?

Yes, this is exactly what I'm using in the follow-up PR #73

philippecamacho · 2025-03-25T19:34:00Z

op-service/crypto/espresso.go

+
+	// Ethereum's eth_sign prefixes the data before signing.
+	// The prefixed message is: "\x19Ethereum Signed Message:\n" + len(data) + data
+	prefixedMsg := fmt.Sprintf("\x19Ethereum Signed Message:\n%d%s", len(data), data)


Not sure we need to do this ourselves. Again, unless we have a good reason not to, we should just use the functions described in https://goethereumbook.org/signature-verify/

dailinsubjam marked this pull request as draft March 14, 2025 06:12

dailinsubjam requested review from Ayiga, philippecamacho, QuentinI and shenkeyao March 14, 2025 06:13

dailinsubjam changed the base branch from celo-integration to celo-integration-rebased March 20, 2025 16:01

dailinsubjam changed the base branch from celo-integration-rebased to celo-integration March 20, 2025 16:06

dailinsubjam force-pushed the sishan/caff_nod branch from 7be4db2 to 403f472 Compare March 20, 2025 16:39

dailinsubjam added 7 commits March 20, 2025 16:43

init push

6e82e6d

init commit

espresso streamer init

34872fe

push today's changes forget to add the file

update Dockerfile related

320fddb

log add caff node config fix config fix the bug...thanks... foget the error handling today's push remove FilterAndFind

adding Verify() to espresso crypto

6ec38f9

added a Verify, but remember to debug commit today's change current change

a compilable version

39f105f

foget to push the file again

remove unused import

82c9e40

rebase to celo-integration-rebased

57e2acf

dailinsubjam force-pushed the sishan/caff_nod branch from 403f472 to 57e2acf Compare March 20, 2025 16:45

dailinsubjam changed the base branch from celo-integration to celo-integration-rebased March 20, 2025 16:46

dailinsubjam added 3 commits March 20, 2025 16:50

remove unneeded file

5bceef2

remove unneeded lines

25a3bce

remove no-needed type

fa52c0d

dailinsubjam commented Mar 20, 2025

View reviewed changes

dailinsubjam marked this pull request as ready for review March 20, 2025 17:12

dailinsubjam added 2 commits March 20, 2025 17:44

add one more TODO

387b0f1

update TODO

d8e32ba

dailinsubjam changed the base branch from celo-integration-rebased to celo-integration March 20, 2025 19:29

shenkeyao reviewed Mar 20, 2025

View reviewed changes

solving comments

f6fb6d9

dailinsubjam requested a review from shenkeyao March 21, 2025 20:22

more comments

f9e400a

philippecamacho reviewed Mar 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Espresso Streamer #66

Add Espresso Streamer #66

dailinsubjam commented Mar 14, 2025 •

edited

Loading

dailinsubjam Mar 20, 2025 •

edited

Loading

shenkeyao Mar 20, 2025

dailinsubjam Mar 21, 2025

shenkeyao Mar 20, 2025

dailinsubjam Mar 21, 2025

shenkeyao Mar 20, 2025

dailinsubjam Mar 21, 2025

shenkeyao Mar 21, 2025

shenkeyao Mar 20, 2025

philippecamacho Mar 25, 2025

philippecamacho Mar 25, 2025 •

edited

Loading

dailinsubjam Mar 25, 2025

philippecamacho Mar 25, 2025

Add Espresso Streamer #66

Are you sure you want to change the base?

Add Espresso Streamer #66

Conversation

dailinsubjam commented Mar 14, 2025 • edited Loading

This PR:

This PR does not:

Key places to review:

dailinsubjam Mar 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philippecamacho Mar 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dailinsubjam commented Mar 14, 2025 •

edited

Loading

dailinsubjam Mar 20, 2025 •

edited

Loading

philippecamacho Mar 25, 2025 •

edited

Loading