fix category view when in landscape #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in the "Sample Categories" view when displayed in landscape orientation. The crash occurred because the code was attempting to use constraints.maxHeight (which is infinite in a vertical scroll area) to calculate card dimensions. The fix ensures card sizing is based solely on constraints.maxWidth, using a 2-column layout in portrait and a 4-column layout in landscape, while also adding a SafeArea to prevent cards from appearing under system controls.
- Replaced conditional logic with a switch expression for cleaner card size calculation
- Changed landscape layout from 2 columns to 4 columns
- Added SafeArea wrapper to prevent content overlap with system UI
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harish-kunchala
approved these changes
Nov 18, 2025
martinoyovo
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "Sample Categories" view, we do some math to determine the width/height of each card. This was throwing an exception in "landscape" orientation. I think it was because we were trying to use
constraints.maxHeightin the formula, which is considered "infinite" when inside a vertical scroll area. So the fix here is to just rely onconstraints.maxWidthand calculate for exactly 4 columns.Also I added a SafeArea so that the cards don't go under the system controls on the sides.
PR best viewed in "Settings > Hide whitespace" mode.