Sample - Show mobile map package expiration date #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eri9000
reviewed
Sep 30, 2025
| @@ -0,0 +1,18 @@ | |||
| package com.esri.arcgismaps.sample.showmobilemappackageexpirationdate | |||
|
|
||
| // Display expiration information overlay if the mobile map package is expired | ||
| if (mapViewModel.isExpired) { | ||
| Surface( |
There was a problem hiding this comment.
you can use a Card here instead of a Surface
...ample/showmobilemappackageexpirationdate/screens/ShowMobileMapPackageExpirationDateScreen.kt
Outdated
Show resolved
Hide resolved
...ample/showmobilemappackageexpirationdate/screens/ShowMobileMapPackageExpirationDateScreen.kt
Outdated
Show resolved
Hide resolved
...ample/showmobilemappackageexpirationdate/screens/ShowMobileMapPackageExpirationDateScreen.kt
Outdated
Show resolved
Hide resolved
Comment on lines
48
to
51
| var expirationMessage by mutableStateOf<String?>(null) | ||
| private set | ||
|
|
||
| var expirationDateText by mutableStateOf<String?>(null) |
There was a problem hiding this comment.
These don't have to be nullable, You can set them to empty or N/A as you are already doing
...showmobilemappackageexpirationdate/components/ShowMobileMapPackageExpirationDateViewModel.kt
Outdated
Show resolved
Hide resolved
…com/esri/arcgismaps/sample/showmobilemappackageexpirationdate/screens/ShowMobileMapPackageExpirationDateScreen.kt Co-authored-by: Erick Lopez Solis <[email protected]>
…com/esri/arcgismaps/sample/showmobilemappackageexpirationdate/screens/ShowMobileMapPackageExpirationDateScreen.kt Co-authored-by: Erick Lopez Solis <[email protected]>
…com/esri/arcgismaps/sample/showmobilemappackageexpirationdate/screens/ShowMobileMapPackageExpirationDateScreen.kt Co-authored-by: Erick Lopez Solis <[email protected]>
…com/esri/arcgismaps/sample/showmobilemappackageexpirationdate/components/ShowMobileMapPackageExpirationDateViewModel.kt Co-authored-by: Erick Lopez Solis <[email protected]>
…-expiration-date' into rom14514/show-mobile-map-package-expiration-date
|
Thanks @eri9000! I addressed your comments, please take another look. |
eri9000
approved these changes
Oct 2, 2025
...ample/showmobilemappackageexpirationdate/screens/ShowMobileMapPackageExpirationDateScreen.kt
Outdated
Show resolved
Hide resolved
shubham7109
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
@rom14514 Sample works well, looks good to me. Added a comment below to help build the string path.
Happy to approve this as I may be ooo.
...showmobilemappackageexpirationdate/components/ShowMobileMapPackageExpirationDateViewModel.kt
Outdated
Show resolved
Hide resolved
...showmobilemappackageexpirationdate/components/ShowMobileMapPackageExpirationDateViewModel.kt
Outdated
Show resolved
Hide resolved
…com/esri/arcgismaps/sample/showmobilemappackageexpirationdate/components/ShowMobileMapPackageExpirationDateViewModel.kt Co-authored-by: Shubham Sharma <[email protected]>
…com/esri/arcgismaps/sample/showmobilemappackageexpirationdate/components/ShowMobileMapPackageExpirationDateViewModel.kt Co-authored-by: Shubham Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a new Kotlin sample "Show mobile map package expiration date" in
Mapscategory.Links and Data
Sample Epic:
runtime/kotlin/issues/ISSUE_NUMBERWhat To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.