Updates to the finding a new home sample to align with 2.4 syntax #2171
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jyaistMap
changed the title
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:58:55Z Rewrite this sentence so the sentence does not contain jumbled characters: Whether their zip code is a buyer’s market or seller’s market.
|
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:58:56Z Is there a reason why it matters whether arcpy is present? I think it would help to explain why it's important to know this. |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:58:57Z It might help to explain to users in a sentence or two what you are about to do. What is this csv collection you are searching for? Was it already created? Why do we need it? What is the data that is in it and why are we downloading it? |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:58:58Z Since you are about to extract the data from the csv collection, it's important to explain to users what that collection is. |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:58:58Z Might help to explain what this is doing with a sentence before you do it. |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:58:59Z The zoom level needs removed from the map initialization as that is no longer supported.
|
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:59:00Z No map appears in the local build of the website. |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:59:01Z The zoom level needs removed from the map initialization. |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:59:01Z The zoom level needs removed from the initialization and added in a cell of its own.
|
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-26T23:59:02Z The zoom level needs removed from the initialization and added in a cell of its own.
|
There was a problem hiding this comment.
- @neha-sharma-geoai
- I think more explanatory text should be added that walks a user through some of what the code is actually doing. The ZipFile and pandas apply code is not easy to decipher what's happening, especially if someone were new to using data frames
- @cariashuang0417
- Many cells have a map zoom in the initialization, which needs removed as you know.
- when building the site locally, no map widgets appears. so that needs addressed.
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2024-11-27T17:52:57Z Might want to disguise your employee number from the output. |
The notebook has been updated on my end. Still, some issues related to maps and import_data are pending which Shuang will take care of.
Checklist
Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.
imports are in the first cell?arcgisimports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.GISobject instantiations are one of the following?gis = GIS()gis = GIS('home')orgis = GIS('pro')gis = GIS(profile="your_online_portal")gis = GIS(profile="your_enterprise_portal")./misc/setup.pyand/or./misc/teardown.py?api_data_owneruser?api_data_owneraccount and change the notebook to first download and unpack the files.<img src="base64str_here">instead of<img src="https://some.url">? All map widgets contain a static image preview? (Callmapview_inst.take_screenshot()to do so)os.path.join()? (Instead ofr"\foo\bar",os.path.join(os.path.sep, "foo", "bar"), etc.)Export Training Data Using Deep Learningtool published on geosaurus org (api data owner account) and added in the notebook usinggis.content.getfunction?gis.content.getfunction? Note: This includes providing test raster and trained model.