chore: updates for 4.31 (#541)

* chore: updates for 4.31 * docs: updating charts samples + tutorials for 4.31 * chore(deps): update (#542) updates dependencies for the 4.31 release * chore: update map and coding components for 4.31 * chore(angular): bump deps * chore(angular): bump deps * Update css * chore(custom-ui): bump deps * chore(custom-workers): update deps * chore(deno): update deps * chore(esm-cdn): update deps * chore(node): update deps * chore(oauth): update deps * chore(react): update deps * chore(vite): update deps * chore(vue): update deps) * chore(rollup): update deps * chore(webpack): update deps * Missed CSS and fix core version * chore: update map and coding comp angular samples * chore: update coding comps cdn sample * Update .github/ISSUE_TEMPLATE/issue-report.yml Co-authored-by: Dasa Paddock <[email protected]> * chore(React): fix core dep * chore: update map and coding component react samples to jsx * chore(map-components): update component styles * chore(map-components): update angular sample for consistent styling * chore(Charts): updated formatting * chore(coding-components): convert react sample to jsx * chore: use require instead of $arcgis in coding comps cdn sample * chore(map and coding components): bump vue version * docs(charts components): remove $arcgis and improved formatting * chore(map and coding components): remove calcite css import * docs(charts-components): addressed feedback * docs(charts-components): removed calcite css * chore(charts-components): increase bundle warning/error size for angular * chore: update formatting * ci: add zip files * ci: analyze core esm sample builds * ci: add zip files * ci: analyze core esm sample builds * ci: add zip files --------- Co-authored-by: jchen <[email protected]> Co-authored-by: Sage Wall <[email protected]> Co-authored-by: manugadde <[email protected]> Co-authored-by: Omar Kawach <[email protected]> Co-authored-by: Dasa Paddock <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Esri · Nov 7, 2024 · 9b28f9a · 9b28f9a
1 parent 899580b
commit 9b28f9a
Show file tree

Hide file tree

Showing 195 changed files with 958 additions and 485,714 deletions.
diff --git a/.github/ISSUE_TEMPLATE/issue-report.yml b/.github/ISSUE_TEMPLATE/issue-report.yml
@@ -48,7 +48,7 @@ body:
     attributes:
       label: Reproduction browser
       description: Browser (check https://whatismybrowser.com/)
-      placeholder: e.g. Chrome 103 on Windows 11
+      placeholder: e.g. Chrome 130 on Windows 11
     validations:
       required: true
   - type: textarea
@@ -58,9 +58,9 @@ body:
       description: Provide the operating system version and device make/model.
       placeholder: |
         - OS:
-            e.g. Apple iOS 15.5, Windows 10* 64-bit or MacOS 12.4
+            e.g. Apple iOS 18, Windows 10* 64-bit or MacOS 14.7
         - Device:
-            e.g. iPhone 13, Samsung Galaxy S22 or Macbook Pro
+            e.g. iPhone 15, Samsung Galaxy S24 or MacBook Pro
         ...
     validations:
       required: true
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -4,7 +4,3 @@ Esri welcomes contributions from anyone and everyone. There are several ways you
 
 * Contact [Esri Tech Support](https://support.esri.com/en-us/contact)
 * Ask the [Esri community](https://community.esri.com/t5/arcgis-javascript-maps-sdk-questions/bd-p/arcgis-api-for-javascript-questions)
-
-# Contributing to this repo
-
-We recommend opening issues before submitting a pull request.
diff --git a/README.md b/README.md
@@ -13,9 +13,9 @@ This repository provides a collection of code samples that provide _proof-of-con
 
 If you have set OAuthInfo's [`popup`](https://developers.arcgis.com/javascript/latest/api-reference/esri-identity-OAuthInfo.html#popup) property to `true`, you'll need to host a [callback page](./oauth/) on your server. For more information, visit the Maps SDK's [Access secure resources](https://developers.arcgis.com/javascript/latest/secure-resources/) guide topic.
 
-## AMD TypeScript declaration files (Deprecated)
+## TypeScript declaration files
 
-The AMD TypeScript `.d.ts` files are deprecated at 4.29 and the final update will be 4.31. The last several files can be downloaded from this [repo](./typescript/README.md). The NPM `.d.ts` files can be installed via the [`arcgis-js-api`](https://www.npmjs.com/package/arcgis-js-api) package, which was also deprecated at 4.29. Use the [`@arcgis/core`](https://www.npmjs.com/package/@arcgis/core) package instead.
+TypeScript definitions are included in the [`@arcgis/core`](https://www.npmjs.com/package/@arcgis/core) npm package.
 
 ## Contributing
 

diff --git a/component-samples/charts-components/README.MD b/component-samples/charts-components/README.MD
@@ -14,3 +14,20 @@ You can use these links to download individual samples:
 - [Vite (no framework)](https://esri.github.io/jsapi-resources/zips/charts-components-sample-vite.zip)
 - [Vue](https://esri.github.io/jsapi-resources/zips/charts-components-sample-vue.zip)
 - [Webpack (no framework)](https://esri.github.io/jsapi-resources/zips/charts-components-sample-webpack.zip)
+
+## Licensing
+Copyright 2024 Esri
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+A copy of the license is available in the repository's [license.txt](https://github.com/Esri/jsapi-resources/blob/master/license.txt) file.
diff --git a/component-samples/charts-components/samples/angular/.gitignore b/component-samples/charts-components/samples/angular/.gitignore
@@ -1,4 +1,4 @@
-# See http://help.github.com/ignore-files/ for more about ignoring files.
+# See https://docs.github.com/get-started/getting-started-with-git/ignoring-files for more about ignoring files.
 
 # Compiled output
 /dist
@@ -10,6 +10,7 @@
 /node_modules
 npm-debug.log
 yarn-error.log
+package-lock.json
 
 # IDEs and editors
 .idea/
@@ -27,6 +28,7 @@ yarn-error.log
 !.vscode/launch.json
 !.vscode/extensions.json
 .history/*
+.editorconfig
 
 # Miscellaneous
 /.angular/cache
@@ -39,11 +41,4 @@ testem.log
 
 # System files
 .DS_Store
-Thumbs.db
-
-# wrappers
-charts-components-angular
-
-# Package lock files
-yarn.lock
-package-lock.json
+Thumbs.db
diff --git a/component-samples/charts-components/samples/angular/README.md b/component-samples/charts-components/samples/angular/README.md
@@ -8,24 +8,17 @@ Run `npm install` and then start adding modules.
 
 For a list of all available `npm` commands see `scripts` in `package.json`, e.g. `npm run build`.
 
-## Known issues
-
-When using Angular 17, for better application load performance with distribution builds it is recommended to use the Webpack builder @angular-devkit/build-angular:browser instead of the default esbuild configuration. This can be configured in the project's angular.json file. More information is available in the [Building Angular apps](https://angular.dev/tools/cli/build) topic on the angular.dev site. At this time esbuild does not offer the ability to customize chunking. That may result in the creation of a significant number of small on-disk bundled files, as well as an increase in the number of files requested by the application at startup. Here is an example snippet:
-
-_angular.json - Webpack configuration_
-
-```json
-      "architect": {
-        "build": {
-          "builder": "@angular-devkit/build-angular:browser",
-          "options": {
-            "outputPath": "dist/",
-            "index": "src/index.html",
-            "main": "src/main.ts",
-            "polyfills": [
-              "zone.js"
-            ],
-          },
-        },
-      }
-```
+## Licensing
+Copyright 2024 Esri
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
diff --git a/component-samples/charts-components/samples/angular/angular.json b/component-samples/charts-components/samples/angular/angular.json
@@ -11,14 +11,19 @@
       "prefix": "app",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular-devkit/build-angular:application",
           "options": {
             "outputPath": "dist/",
             "index": "src/index.html",
-            "main": "src/main.ts",
+            "browser": "src/main.ts",
             "polyfills": ["zone.js"],
             "tsConfig": "tsconfig.app.json",
-            "assets": ["src/favicon.ico"],
+            "assets": [
+              {
+                "glob": "**/*",
+                "input": "public"
+              }
+            ],
             "styles": ["src/styles.css"],
             "scripts": []
           },
@@ -27,8 +32,8 @@
               "budgets": [
                 {
                   "type": "initial",
-                  "maximumWarning": "500kb",
-                  "maximumError": "1mb"
+                  "maximumWarning": "2mb",
+                  "maximumError": "5mb"
                 },
                 {
                   "type": "anyComponentStyle",
@@ -59,22 +64,27 @@
           "defaultConfiguration": "development"
         },
         "extract-i18n": {
-          "builder": "@angular-devkit/build-angular:extract-i18n",
-          "options": {
-            "buildTarget": "charts-components-angular-sample:build"
-          }
+          "builder": "@angular-devkit/build-angular:extract-i18n"
         },
         "test": {
           "builder": "@angular-devkit/build-angular:karma",
           "options": {
             "polyfills": ["zone.js", "zone.js/testing"],
             "tsConfig": "tsconfig.spec.json",
-            "assets": ["src/favicon.ico", "src/assets"],
+            "assets": [
+              {
+                "glob": "**/*",
+                "input": "public"
+              }
+            ],
             "styles": ["src/styles.css"],
             "scripts": []
           }
         }
       }
     }
+  },
+  "cli": {
+    "analytics": false
   }
 }
diff --git a/component-samples/charts-components/samples/angular/package.json b/component-samples/charts-components/samples/angular/package.json
@@ -4,38 +4,38 @@
   "private": true,
   "scripts": {
     "ng": "ng",
-    "start": "ng serve  --force-esbuild",
+    "start": "ng serve",
     "build": "ng build",
     "watch": "ng build --watch --configuration development",
     "test": "ng test"
   },
   "dependencies": {
-    "@angular/animations": "^17.3.6",
-    "@angular/common": "^17.3.6",
-    "@angular/compiler": "^17.3.6",
-    "@angular/core": "^17.3.6",
-    "@angular/forms": "^17.3.6",
-    "@angular/platform-browser": "^17.3.6",
-    "@angular/platform-browser-dynamic": "^17.3.6",
-    "@angular/router": "^17.3.6",
-    "@arcgis/charts-components-angular": "~4.30.0",
-    "@arcgis/charts-model": "~4.30.0",
-    "@arcgis/core": "~4.30.0",
+    "@angular/animations": "^18.2.0",
+    "@angular/common": "^18.2.0",
+    "@angular/compiler": "^18.2.0",
+    "@angular/core": "^18.2.0",
+    "@angular/forms": "^18.2.0",
+    "@angular/platform-browser": "^18.2.0",
+    "@angular/platform-browser-dynamic": "^18.2.0",
+    "@angular/router": "^18.2.0",
+    "@arcgis/charts-components": "~4.31.0",
+    "@arcgis/charts-model": "~4.31.0",
+    "@arcgis/core": "~4.31.0",
     "rxjs": "~7.8.0",
     "tslib": "^2.3.0",
-    "zone.js": "~0.14.5"
+    "zone.js": "~0.14.10"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "^17.3.6",
-    "@angular/cli": "^17.3.6",
-    "@angular/compiler-cli": "^17.3.6",
+    "@angular-devkit/build-angular": "^18.2.0",
+    "@angular/cli": "^18.2.0",
+    "@angular/compiler-cli": "^18.2.0",
     "@types/jasmine": "~5.1.0",
-    "jasmine-core": "~5.1.0",
+    "jasmine-core": "~5.2.0",
     "karma": "~6.4.0",
     "karma-chrome-launcher": "~3.2.0",
     "karma-coverage": "~2.2.0",
     "karma-jasmine": "~5.1.0",
     "karma-jasmine-html-reporter": "~2.1.0",
-    "typescript": "~5.4.5"
+    "typescript": "~5.5.2"
   }
 }
diff --git a/component-samples/charts-components/samples/angular/src/app/app.component.css b/component-samples/charts-components/samples/angular/src/app/app.component.css
@@ -1,3 +1 @@
-.chart-component {
-  height: 800px;
-}
+@import url('https://js.arcgis.com/4.31/@arcgis/core/assets/esri/themes/dark/main.css');
diff --git a/component-samples/charts-components/samples/angular/src/app/app.component.html b/component-samples/charts-components/samples/angular/src/app/app.component.html
@@ -1 +1,3 @@
-<arcgis-charts-scatter-plot #scatterplot class="chart-component"></arcgis-charts-scatter-plot>
+<arcgis-charts-scatter-plot #scatterplot class="chart-component">
+  <arcgis-charts-action-bar slot="action-bar" id="scatterplot-action-bar"></arcgis-charts-action-bar>
+</arcgis-charts-scatter-plot>
diff --git a/component-samples/charts-components/samples/angular/src/app/app.component.spec.ts b/component-samples/charts-components/samples/angular/src/app/app.component.spec.ts