-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing style.css file to initial download #545
Conversation
This is ready for review, the draft tag is just there to prevent the zips from being generated for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new file is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a comment on why this is empty if that's intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I agree it's a strange commit. style.css
is intended to be included in the initial download starter project as a blank file. It's imported in starter main.js
and leads to build errors and confusion where the tutorial assumes the empty file exists. I guess we could consider editing the tutorial to create the file but this seems like the easier path forward for now is to add the empty style.css
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe added a css comment to the file saying that styles should be added here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added 😃
The create a web app using components initial download is missing the
style.css
file. This PR adds the missing blank file.