-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add ability to register custom item transformers. #4871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
|
Thanks for your interest in contributing to EssentialsX! As it stands, |
|
It's been a while, just would like to see if this could still be merged as the rework to |
|
Heyo! I recently found a need for this again and wanted to know if this could get merged in quickly. Thanks! |
JRoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit + fix the formatting issues + fix the merge conflicts
|
I've addressed the changes. Should I modify anything else? |
JRoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some final codestyle nits
Essentials/src/main/java/com/earth2me/essentials/utils/StringUtil.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/items/transform/PluginItemTransformer.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/items/transform/PluginItemTransformer.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java
Outdated
Show resolved
Hide resolved
|
Addressed! |
|
I flattened the commits and updated my usage of the logger. |
Information
This PR closes Nothing.
Details
Proposed feature:
A system to allow plugin developers to add custom item transformers to metadata on items. Would be useful for plugins seeking to add custom item templates that could be dynamic or have special data on the item.
Environments tested:
OS: Windows 10
Java version: 1.8.0_281
Demonstration:
A demonstration isn't fully applicable to the situation as it's not something that immediately affects anything.