Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Folia #5291

Draft
wants to merge 24 commits into
base: 2.x
Choose a base branch
from
Draft

Add support for Folia #5291

wants to merge 24 commits into from

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Mar 29, 2023

this barely works

todo;

  • validate timer race conditions
  • fix the tps command shit
  • InteractionControllerImpl commands don't fucking fire, need to figure out what im going to do, need to delegate threads for commands to run OUTside of the jda event but also get some of that off netty threads
  • review everything ran on global thread
  • entire discord module probably doesn't work
  • finish static accesses to the scheduler
  • what are we doing with api events

@JRoy JRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module module: discord Issues or PRs for the EssentialsDiscord module module: chat Issues or PRs for the EssentialsChat module module: spawn Issues or PRs for the EssentialsSpawn module module: geo Issues or PRs for the EssentialsGeo module module: antibuild Issues or PRs for the EssentialsAntiBuild module module: protect Issues or PRs for the EssentialsProtect module labels Mar 29, 2023
@JRoy JRoy added this to the 2.20.0 milestone Mar 29, 2023
@JRoy JRoy marked this pull request as draft March 29, 2023 23:15
@JRoy JRoy modified the milestones: 2.20.0, 2.21.0 Apr 28, 2023
@cgw2023
Copy link

cgw2023 commented Jun 20, 2023

there is a problem with essentialsSpawn folia
respawn-listener is not working
no matter how i tune

respawn-listener-priority: high
spawn-join-listener-priority: high
respawn-at-home: false
respawn-at-home-bed: true

player die will not go back to essentials spawn point if no vanilla spawnpoint, bed and home is set

this does not happen in paper/spigot

@ghost

This comment was marked as spam.

@xcomcadx

This comment was marked as spam.

@iLemon
Copy link

iLemon commented Jul 27, 2023

This PR runs well on folia 1.20.1 for me.

The only minor issue I've encountered so far is the time and weather setting commands give an error:
CleanShot 2023-07-27 at 17 48 13@2x

The vanilla command (/minecraft:time set day) work fine so this is really minor.

JRoy added 4 commits July 27, 2023 19:30
# Conflicts:
#	EssentialsDiscord/src/main/java/net/essentialsx/discord/util/ConsoleInjector.java
@JRoy
Copy link
Member Author

JRoy commented Jul 28, 2023

Updated to latest 2.x and fixed time + weather command

@iLemon
Copy link

iLemon commented Jul 31, 2023

The time and weather commands now show a success message but doesn't seem to actually have an effect on the time/weather.

[17:46:45] [Region Scheduler Thread #1/INFO]: iLemon issued server command: /time night
[17:46:45] [Region Scheduler Thread #1/WARN]: [Essentials] Location task for Essentials v2.20.1-dev+67-0c8bc16 in world CraftWorld{name=world} at 0, 0 generated an exception
java.lang.IllegalStateException: Cannot modify time off of the global region
	at io.papermc.paper.threadedregions.RegionizedServer.ensureGlobalTickThread(RegionizedServer.java:106) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at org.bukkit.craftbukkit.v1_20_R1.CraftWorld.setTime(CraftWorld.java:858) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at com.earth2me.essentials.commands.Commandtime.lambda$run$0(Commandtime.java:92) ~[EssentialsX-2.20.1-dev+67-0c8bc16.jar:?]
	at io.papermc.paper.threadedregions.scheduler.FoliaRegionScheduler.lambda$wrap$0(FoliaRegionScheduler.java:35) ~[folia-1.20.1.jar:?]
	at io.papermc.paper.threadedregions.RegionizedTaskQueue$PrioritisedQueue$ChunkBasedPriorityTask.executeInternal(RegionizedTaskQueue.java:504) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at io.papermc.paper.threadedregions.RegionizedTaskQueue$PrioritisedQueue.executeTask(RegionizedTaskQueue.java:434) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at io.papermc.paper.threadedregions.RegionizedTaskQueue$RegionTaskQueueData.drainTasks(RegionizedTaskQueue.java:263) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1514) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.1.jar:git-Folia-"daacd42"]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

@Git-North
Copy link

I thought weather commands were disabled on folia

JRoy added 2 commits August 22, 2023 11:37
# Conflicts:
#	Essentials/src/main/java/com/earth2me/essentials/commands/Commandskull.java
@JRoy
Copy link
Member Author

JRoy commented Aug 22, 2023

Fixed the commands again

@LuluxClient
Copy link

Everything works fine except the respawn feature (tested from the previous comment to see if it was still an issue)

@DarkyG2
Copy link

DarkyG2 commented Sep 25, 2023

No issues on my end after testing it on prod, would love to see a merge to the main branch

@nyancat-hu

This comment was marked as off-topic.

@DarkyG2
Copy link

DarkyG2 commented Feb 6, 2024

Small issue with commands in kits, I'm getting the error "[22:57:44 WARN]: [Essentials] Dispatching command async" and that's it and I won't receive the items executed thru a command

@Potothingi

This comment has been minimized.

@RitaSister

This comment has been minimized.

@TATA82
Copy link

TATA82 commented May 11, 2024

folia support is work 1.20.6?

@RitaSister
Copy link

folia support is work 1.20.6?

no, doesn't support

@RitaSister

This comment was marked as off-topic.

@Q2297045667
Copy link

Will 1.21 be updated?

@mdcfe mdcfe modified the milestones: 2.21.0, 2.22.0 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: antibuild Issues or PRs for the EssentialsAntiBuild module module: chat Issues or PRs for the EssentialsChat module module: discord Issues or PRs for the EssentialsDiscord module module: geo Issues or PRs for the EssentialsGeo module module: main Issues or PRs for the main Essentials module module: protect Issues or PRs for the EssentialsProtect module module: spawn Issues or PRs for the EssentialsSpawn module type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.