Skip to content
This repository has been archived by the owner on Nov 28, 2021. It is now read-only.

Should we use SafeMath from OpenZeppelin? #86

Closed
acuarica opened this issue Nov 22, 2021 · 3 comments · May be fixed by #77
Closed

Should we use SafeMath from OpenZeppelin? #86

acuarica opened this issue Nov 22, 2021 · 3 comments · May be fixed by #77
Labels
review Further information is requested
Projects

Comments

@acuarica
Copy link
Contributor

acuarica commented Nov 22, 2021

As mentioned in https://blog.openzeppelin.com/openzeppelin-contracts-4-0/

[...] Solidity 0.8 marks the end of the SafeMath era, as overflow checks are now built into the compiler.

You will find that SafeMath is still in the repository, athough it is now just a wrapper over the built-in overflow checks.

I see no point in use SafeMath. Am I missing something @fede-rodes?

@acuarica acuarica created this issue from a note in Ren Pool (To do) Nov 22, 2021
@acuarica acuarica added the review Further information is requested label Nov 22, 2021
@acuarica acuarica changed the title use safeMath Should we use SafeMath from OpenZeppelin? Nov 22, 2021
@fede-rodes
Copy link
Member

@acuarica agree, seems like there is no need for this library anymore

@acuarica
Copy link
Contributor Author

We can remove TODO below then

// TODO: use safeMath

@acuarica
Copy link
Contributor Author

Migrated to new repo.

Ren Pool automation moved this from To do to Done Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
review Further information is requested
Projects
Development

Successfully merging a pull request may close this issue.

2 participants