Ref/update claim rewards interface #77
Conversation
…te-claim-rewards-interface
…te-claim-rewards-interface
client/src/constants.ts
Outdated
| 1: { | ||
| REN_TOKEN: '0x408e41876cCCDC0F92210600ef50372656052a38', | ||
| DARKNODE_REGISTRY: '0x2D7b6C95aFeFFa50C068D50f89C5C0014e054f0A', | ||
| REN_POOL: '0x0000000000000000000000000000000000000000', | ||
| }, | ||
| 42: { | ||
| REN_TOKEN: '0x2CD647668494c1B15743AB283A0f980d90a87394', | ||
| DARKNODE_REGISTRY: '0x9954C9F839b31E82bc9CA98F234313112D269712', |
There was a problem hiding this comment.
Here I see we repeating ourselves with addresses configuration. We already have that configuration in Hardhat, we need to undertand the best way to reuse from both projects.
There was a problem hiding this comment.
Agree. I'll give it some thought. The only address that changes (but still we should be able to store it somewhere at deploy time) is the RenPool address.
There was a problem hiding this comment.
In PR #88 I tried to reuse contract address from client.
| @@ -18,6 +18,7 @@ | |||
| "@nomiclabs/hardhat-etherscan": "^2.1.3", | |||
| "@nomiclabs/hardhat-waffle": "^2.0.0", | |||
| "@openzeppelin/contracts": "^4.3.3", | |||
| "@renproject/gateway-sol": "^1.0.10", | |||
There was a problem hiding this comment.
It seems that this package is causing troubles in CI
https://github.com/Ethernautas/renpool/runs/4314560392?check_suite_focus=true#step:3:20
I believe because the openzeppelin versions used by them and us are different.
There was a problem hiding this comment.
ok, I'll look into this 👍
* Export contract artifacts to be used by client * Reuse Ren contract addresses from `client` * Tune `deployments` type to restrict keys
@acuarica have a look at the
should transfer rewards to darknode ownertest, it's now passing so the call to the seems to be going through. In theory we should call gateway.mint after that