-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export to csv and Stuff! #462
Merged
EtienneLamoureux
merged 14 commits into
EtienneLamoureux:master
from
hguy:export-to-csv-rebased
Aug 17, 2022
Merged
Export to csv and Stuff! #462
EtienneLamoureux
merged 14 commits into
EtienneLamoureux:master
from
hguy:export-to-csv-rebased
Aug 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # TQVaultAE.sln # documentation/FORGE.md # documentation/HIGHLIGHT.md # documentation/highlight_ui_extended.png # src/TQVaultAE.Data/ItemProvider.cs # src/TQVaultAE.Data/LootTableCollectionProvider.cs # src/TQVaultAE.Domain/Contracts/Providers/IItemProvider.cs # src/TQVaultAE.Domain/Contracts/Providers/ILootTableCollectionProvider.cs # src/TQVaultAE.Domain/Contracts/Services/ITranslationService.cs # src/TQVaultAE.Domain/Entities/GameExtension.cs # src/TQVaultAE.Domain/Entities/GearLevel.cs # src/TQVaultAE.Domain/Entities/HighlightFilterValues.cs # src/TQVaultAE.Domain/Entities/Item.cs # src/TQVaultAE.Domain/Entities/RelicAndCharm.cs # src/TQVaultAE.Domain/Entities/SessionContext.cs # src/TQVaultAE.Domain/Entities/Variable.cs # src/TQVaultAE.Domain/Heplers/RelicAndCharmExtension.cs # src/TQVaultAE.Domain/Heplers/StringHelper.cs # src/TQVaultAE.Domain/Results/ToFriendlyNameResult.cs # src/TQVaultAE.GUI/Components/EquipmentPanel.cs # src/TQVaultAE.GUI/Components/ForgePanel.cs # src/TQVaultAE.GUI/Components/HighlightFilters.Designer.cs # src/TQVaultAE.GUI/Components/HighlightFilters.cs # src/TQVaultAE.GUI/Components/SackPanel.cs # src/TQVaultAE.GUI/Components/VaultPanel.cs # src/TQVaultAE.GUI/MainForm.Forge.cs # src/TQVaultAE.GUI/MainForm.cs # src/TQVaultAE.GUI/SearchDialogAdvanced.cs # src/TQVaultAE.Presentation/Resources.fr.resx # src/TQVaultAE.Presentation/Resources.resx # src/TQVaultAE.Presentation/TranslationService.cs
ef861d1
to
ef39a98
Compare
ef39a98
to
b50a06d
Compare
9689e30
to
a1968d4
Compare
Item relic overlay didn't show for second relic. Advanced Search saved queries didn't persist. Fix false positive on `Item.IsImmortalThrone, Item.IsRagnarok, Item.IsAtlantis` Better affixes data extraction
a1968d4
to
956e732
Compare
Item relic overlay didn't show for second relic. Advanced Search saved queries didn't persist. Fix false positive on `Item.IsImmortalThrone, Item.IsRagnarok, Item.IsAtlantis` Better affixes data extraction
956e732
to
730cfc9
Compare
# Conflicts: # src/ARZExplorer/MainForm.cs # src/TQVaultAE.Data/ArcFileProvider.cs # src/TQVaultAE.Data/Database.cs # src/TQVaultAE.Data/ItemProvider.cs # src/TQVaultAE.Data/LootTableCollectionProvider.cs # src/TQVaultAE.Domain/Entities/BagButtonIconInfo.cs # src/TQVaultAE.Domain/Entities/Info.cs # src/TQVaultAE.Domain/Entities/RecordId.cs # src/TQVaultAE.Domain/Entities/RelicAndCharm.cs # src/TQVaultAE.Domain/Heplers/StringHelper.cs # src/TQVaultAE.GUI/Components/ForgePanel.cs # src/TQVaultAE.Presentation/UIService.cs # src/TQVaultAE.Services.Win32/SoundServiceWin.cs
f0d7499
to
bc25338
Compare
d56a562
to
1b03d6b
Compare
1b03d6b
to
fc0dd2f
Compare
3e20e70
to
9a81a11
Compare
871180f
to
3c83bf5
Compare
EtienneLamoureux
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CSV export as suggested in #437.
Translation : EN/FR.
Context menu
Settings
Added documentation for Arz Explorer & Save File Explorer
https://github.com/hguy/TQVaultAE/blob/export-to-csv/documentation/ARZEXPLORER.md
https://github.com/hguy/TQVaultAE/blob/export-to-csv/documentation/SAVEFILEEXPLORER.md
Added documentation for advanced search
https://github.com/hguy/TQVaultAE/blob/export-to-csv/documentation/ADVANCEDSEARCH.md
Added advanced search category filtering
Strongly Typed RecordId
unaltered
string recordId
has become more valuable over time mostly for display reasons (Prefix/Suffix).NormalizeRecordPath(string recordId)
was everywhere and string mutation was paid everytime.The need for a structure that nullify
string recordId
case sensitivity during comparison (Equal, Comparable) and preserve the raw value was strong.Now all
string recordId
are defined asclass RecordId
.class RecordId
embed theRaw
value andNormalized
value.The
Normalized
is used for comparison and paid once, theRaw
for display and persistance.It support common operators
Equals(), <, >, ==, !=
.You can produce a
class RecordId
instance from astring
using the following.mystringinstance.ToRecordId()
,StringHelper.ToRecordId(string recordId)
RecordId.Create(string recordId)
RecordId myrecordId = "\\record\\something.dbr"; // goes both directions
RecordId myrecordId = (RecordId)"\\record\\something.dbr";
RecordId recommendations
RecordId
in your scope (method, object). instanciate it once explicitely and reuse it.Improvements
Better affixes data extraction
Improved overall stability while custom map enabled
Fixes
Item relic overlay didn't show for second relic.
Advanced Search saved queries didn't persist.
Fix false positive on
Item.IsImmortalThrone, Item.IsRagnarok, Item.IsAtlantis
Fix Reset Mastery problem #455
Fix #464 Empty vault directory bug
Fix #405 difficulty unlocked override
Fix #279 startup error
Fix #243 by showing icons and tooltip info
Affixes for unique
This last step allow affixes pickup for uniques. It try to suck all known Prefix/Suffix per gear type (e.g, all affixes for axe if the unique is an axe).



Local directory userSettings.
Old user.config settings are in sub directories of "%USERPROFILE%\AppData\Local\titanquest.net_community".
It was a pain for users and the source of too many misunderstanding during support, so i move all userSettings
into
UserConfig.xml
which is deployed with the executable.From now on, it's the dedicated file for all user level configuration.
It is programmatically used in an exact similar way as the standard .NET class except we control the path.
Examples:
The FAQ is adjusted accordingly.
Note : If the user reuse the same directory with this new version, an error can happen preventing the tool to launch. Two solutions possible.