Skip to content

Conversation

@qsantos
Copy link
Contributor

@qsantos qsantos commented Nov 13, 2024

I mostly wanted to dbg! the server's Session, but I took the opportunity to add #[derive(Debug)] wherever I could.

@Eugeny
Copy link
Owner

Eugeny commented Nov 13, 2024

A lot of these are empty structs and structs with security relevant fields that should not end up in some forgotten dbg! output. I could merge a handmade Debug impl with just the relevant fields for Session but not this.

@qsantos
Copy link
Contributor Author

qsantos commented Nov 14, 2024

I have excluded the private keys from the Debug implementation of the server Session, but I probably missed some other secrets.

@Eugeny Eugeny merged commit 981cf7b into Eugeny:main Nov 17, 2024
@Eugeny
Copy link
Owner

Eugeny commented Nov 17, 2024

LGTM! @all-contributors add @qsantos for code

@allcontributors
Copy link
Contributor

@Eugeny

I've put up a pull request to add @qsantos! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants