Make Config accessor methods for user/port/host public #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you! |
Owner
|
@all-contributors add @packetsource for code |
Contributor
|
@packetsource already contributed before to code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
russh_config::Config struct has gone private. But it's not unreasonable for client apps using parse_home() and friends to want to inspect the results of the excellent ssh_config parsing code, eg. host1 maps to user foo@bar:2022 etc etc., so they can print progress/diagnostic messages. There are some helpful accessor functions for user/port/host, but they are not public, so this PR simply marks those methods public.