fixed duplicate multiline-paste prompts

Eugeny · Mar 1, 2024 · 3f160ee · 3f160ee
1 parent 5d8ff72
commit 3f160ee
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/tabby-core/src/components/baseTab.component.ts b/tabby-core/src/components/baseTab.component.ts
@@ -226,7 +226,6 @@ export abstract class BaseTabComponent extends BaseComponent {
             this.destroyed.next()
         }
         this.destroyed.complete()
-        this.hostView.destroy()
     }
 
     /** @hidden */

diff --git a/tabby-core/src/components/splitTab.component.ts b/tabby-core/src/components/splitTab.component.ts
@@ -767,10 +767,10 @@ export class SplitTabComponent extends BaseTabComponent implements AfterViewInit
     }
 
     destroy (): void {
-        super.destroy()
         for (const x of this.getAllTabs()) {
             x.destroy()
         }
+        super.destroy()
     }
 
     layout (): void {

diff --git a/tabby-core/src/services/tabs.service.ts b/tabby-core/src/services/tabs.service.ts
@@ -37,6 +37,7 @@ export class TabsService {
         const componentRef = componentFactory.create(this.injector)
         const tab = componentRef.instance
         tab.hostView = componentRef.hostView
+        tab.destroyed$.subscribe(() => componentRef.destroy())
         Object.assign(tab, params.inputs ?? {})
         return tab
     }