Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setting to hide tray (menubar for macos) #9624

Merged
merged 3 commits into from
Jun 19, 2024
Merged

add setting to hide tray (menubar for macos) #9624

merged 3 commits into from
Jun 19, 2024
+20 −1

Conversation

C41M50N
Copy link
Contributor

@C41M50N C41M50N commented May 7, 2024

fixes #4955 (I know it's marked as completed, but it was never implemented from what I can see)

@C41M50N
Copy link
Contributor Author

C41M50N commented Jun 17, 2024

@Eugeny any thoughts on this?

@Eugeny
Copy link
Owner

Eugeny commented Jun 17, 2024

Sorry for the delay, I'm completely overwhelmed with work right now. Looks good, left 2 notes

@C41M50N
Copy link
Contributor Author

C41M50N commented Jun 17, 2024 •
edited
Loading

No worries, thanks for taking the time. I made changes to accomodate those notes.

Another issue that I am seeing is that the 'showTray' config is not added to the config file if it doesn't exist (and is therefore out-of-sync with the toggle). Is there a standard way of handling the case where a config option is added if it is not already set?

@Eugeny
Copy link
Owner

Eugeny commented Jun 18, 2024

No, unfortunately the main process doesn't have access to the same merged "defaults + user settings" object, so all access to configStore has to have a ?? default slapped onto it.

@C41M50N
Copy link
Contributor Author

C41M50N commented Jun 19, 2024

Okay. I've made that change as well as shifted to 'hide tray' instead of 'show tray'. That way the default will be false. Let me know if there's anything else that needs changes.

@Eugeny Eugeny merged commit db2280e into Eugeny:master Jun 19, 2024
10 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Jun 19, 2024

LGTM, thanks!

@all-contributors please add @C41M50N for code

@allcontributors allcontributors bot mentioned this pull request Jun 19, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@Eugeny

I've put up a pull request to add @C41M50N! 🎉

widhaprasa added a commit to widhaprasa/tabby that referenced this pull request Jun 26, 2024
@widhaprasa
Squashed commit of the following:
4690910 
commit bba72b4
Author: Eugene <[email protected]>
Date:   Sat Jun 22 21:43:37 2024 +0200

    fixed Eugeny#9698, fixed Eugeny#9697, fixed Eugeny#9651, fixed Eugeny#8371, fixed Eugeny#9483 - fixed huge search bar

commit 3739455
Merge: ab48990 1776b84
Author: Eugene <[email protected]>
Date:   Sat Jun 22 21:36:49 2024 +0200

    Merge branch 'master' of github.com:Eugeny/tabby

commit ab48990
Author: Eugene <[email protected]>
Date:   Sat Jun 22 21:36:46 2024 +0200

    export SSHMultiplexerService

commit 1776b84
Merge: db2280e 3ea1b7f
Author: Eugene <[email protected]>
Date:   Wed Jun 19 12:24:14 2024 +0200

    Merge pull request Eugeny#9721 from Eugeny/all-contributors/add-C41M50N

    add C41M50N as a contributor for code

commit 3ea1b7f
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:22:22 2024 +0000

    update README.pt-BR.md [skip ci]

commit cee39b3
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:21:53 2024 +0000

    update README.ja-JP.md [skip ci]

commit 218fb81
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:21:49 2024 +0000

    update README.es-ES.md [skip ci]

commit d718f43
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:21:24 2024 +0000

    update .all-contributorsrc [skip ci]

commit defe307
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:21:21 2024 +0000

    update README.id-ID.md [skip ci]

commit a3a6e3d
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:20:45 2024 +0000

    update README.de-DE.md [skip ci]

commit a5f4f23
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:20:44 2024 +0000

    update README.it-IT.md [skip ci]

commit bdcfba1
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:20:43 2024 +0000

    update README.ko-KR.md [skip ci]

commit e120031
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:20:42 2024 +0000

    update README.ru-RU.md [skip ci]

commit 5adfdd4
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:20:41 2024 +0000

    update README.zh-CN.md [skip ci]

commit 897e06d
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Wed Jun 19 10:20:40 2024 +0000

    update README.md [skip ci]

commit db2280e
Merge: c681902 8a49c73
Author: Eugene <[email protected]>
Date:   Wed Jun 19 12:20:24 2024 +0200

    Merge pull request Eugeny#9624 from C41M50N/feature/hide-tray

    add setting to hide tray (menubar for macos)

commit 8a49c73
Author: Charles Buffington <[email protected]>
Date:   Tue Jun 18 17:05:19 2024 -0400

    change from 'show tray' to 'hide tray'

commit 439a7a8
Author: Charles Buffington <[email protected]>
Date:   Mon Jun 17 19:26:39 2024 -0400

    move 'show tray' setting to window settings

commit c681902
Merge: de81f12 a3fd6f5
Author: Eugene <[email protected]>
Date:   Sat May 25 21:58:05 2024 +0200

    Merge pull request Eugeny#9673 from orthlus/patch-1

    typos russian README

commit a3fd6f5
Author: Ort <[email protected]>
Date:   Sat May 25 17:08:43 2024 +0300

    typos russian README

commit de81f12
Merge: d15b67a 242f136
Author: Eugene <[email protected]>
Date:   Sun May 19 10:18:15 2024 +0200

    Merge pull request Eugeny#9657 from RiccardoManzan/fix-cli-on-linux-Eugeny#9656

    Eugeny#9656 fix: cli usage on linux

commit 242f136
Author: Riccardo Manzan <[email protected]>
Date:   Sat May 18 13:59:21 2024 +0200

    Eugeny#9656 fix: cli usage on linux

commit 9425920
Author: Charles Buffington <[email protected]>
Date:   Tue May 7 12:13:19 2024 -0400

    add setting to hide tray (menubar for macos)

commit d15b67a
Merge: 8f68105 8237785
Author: Eugene <[email protected]>
Date:   Tue Apr 2 19:50:45 2024 +0200

    Merge pull request Eugeny#9571 from Tbhesswebber/patch-1

    docs(hacking): adds clarification for installing forks

commit 8237785
Author: Tanner B. Hess Webber <[email protected]>
Date:   Tue Apr 2 11:10:02 2024 -0400

    docs(hacking): adds clarification for installing forks

commit 8f68105
Merge: 24c64a5 66b7632
Author: Eugene <[email protected]>
Date:   Wed Mar 27 09:21:51 2024 +0100

    Merge pull request Eugeny#9546 from bc547-dev/master

    Make autoSync more robust for network errors

commit 66b7632
Author: bc547 <[email protected]>
Date:   Mon Mar 25 16:21:08 2024 +0100

    Fix lint error

    Change double quote to single quote for string

commit c906af5
Author: bc547 <[email protected]>
Date:   Sat Mar 23 10:05:28 2024 +0100

    Make autoSync more robust for network errors

    Catch uncaught error in autoSync that caused autoSync to stop syncing

commit 24c64a5
Author: Eugene <[email protected]>
Date:   Tue Mar 12 09:03:31 2024 +0100

    Update docs.yml

commit ebf0d89
Author: Eugene <[email protected]>
Date:   Mon Mar 11 21:31:54 2024 +0100

    bumped xterm to 5.4.0

commit bacb458
Author: Eugene <[email protected]>
Date:   Mon Mar 11 21:20:51 2024 +0100

    fixed Eugeny#9164 - only auto-open a new tab if there are no tabs recovered after startup

commit 49d05cc
Author: Eugene <[email protected]>
Date:   Mon Mar 11 21:15:59 2024 +0100

    updated locales, added Turkish and Serbian languages

commit 0894c30
Author: Eugene <[email protected]>
Date:   Mon Mar 11 21:10:39 2024 +0100

    fixed Eugeny#9482 - dragged-in panes going to sleep after some time

commit c3baad4
Merge: fc72b4d 3b15b35
Author: Eugene <[email protected]>
Date:   Sun Mar 10 21:14:01 2024 +0100

    Merge pull request Eugeny#9512 from Clem-Fern/gconf2-dep

    electron-builder: remove gconf dependencies from deb package

commit 3b15b35
Author: Clem <[email protected]>
Date:   Sun Mar 10 15:38:02 2024 +0100

    electron-builder: remove gconf dependencies from deb package Eugeny#9457 Eugeny#9340 Eugeny#9219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eugeny Eugeny Eugeny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Option to hide the MacOS menu icon
2 participants
@C41M50N @Eugeny