add ansible/lint #8
Conversation
|
Fixed after merging separate PR and rebasing this branch. |
Makefile
Outdated
| @@ -126,3 +127,8 @@ deploy/provision: | |||
| deploy/app: | |||
| @echo "Deploying version $(V) to a remote server" | |||
| $(DEPLOY_CMD) playbooks/03_app.yml --extra-vars "app_version=$(V)" | |||
|
|
|||
| deploy/lint: | |||
There was a problem hiding this comment.
Why? Liniting should happen before the files get deployed?
See: https://blog.42mate.com/installing-and-using-pre-commit-with-ansible-lint/
There was a problem hiding this comment.
Or before they get pushed, yes. The deploy/ here is to separate from make lint which lints the source/app.
Another option would be to make it lint/deploy target or something like that. WDYT?
There was a problem hiding this comment.
Aehm yes. Before push. Or at least before merge.
So either it is just "lint" if you want to execute manually. But I will forget to do this. Or you add a pre-commit hook to it. Like at website.
There was a problem hiding this comment.
Yes, and the next step would be to add it here: https://github.com/EuroPython/internal-bot/pull/3/files :)
It currently only runs tests, but the goal is to also run linter as part of the same checks.
There was a problem hiding this comment.
Fixed after rebasing on the new CI/CD setup. Now lint/deploy is run as part of build
Co-authored-by: Cyril Bitterich <[email protected]>
Co-authored-by: Cyril Bitterich <[email protected]>
Co-authored-by: Cyril Bitterich <[email protected]>
|
|
||
| - name: Restart everything and finish | ||
| shell: "docker compose up -d" | ||
| ansible.builtin.command: |
There was a problem hiding this comment.
Me not likey ansible.builtin.cmd. You could use community.docker.docker_compose_v2
E.g. https://github.com/EuroPython/infra/blob/53c2fa4d997929a095fa4b10144baa0a34b05ce7/playbooks/roles/zammad/tasks/main.yaml#L49
| changed_when: output.rc != 0 | ||
| failed_when: output.rc != 0 |
There was a problem hiding this comment.
This does not make sense. How should ansible know if this has failed or changed if the conditional is the same?
For ansible:
changed = continue
failed = stop here
| changed_when: output.rc != 0 | ||
| failed_when: output.rc != 0 |
There was a problem hiding this comment.
This does not make sense. How should ansible know if this has failed or changed if the conditional is the same?
For ansible:
changed = continue
failed = stop here
| changed_when: output.rc != 0 | ||
| failed_when: output.rc != 0 |
There was a problem hiding this comment.
This does not make sense. How should ansible know if this has failed or changed if the conditional is the same?
For ansible:
changed = continue
failed = stop here
| changed_when: output.rc != 0 | ||
| failed_when: output.rc != 0 |
There was a problem hiding this comment.
This does not make sense. How should ansible know if this has failed or changed if the conditional is the same?
For ansible:
changed = continue
failed = stop here
| chdir: "{{ ansible_user_dir }}" | ||
| cmd: "docker compose up -d" |
There was a problem hiding this comment.
Me not likey ansible.builtin.cmd. You could use community.docker.docker_compose_v2
E.g. https://github.com/EuroPython/infra/blob/53c2fa4d997929a095fa4b10144baa0a34b05ce7/playbooks/roles/zammad/tasks/main.yaml#L49
| @@ -15,6 +15,7 @@ CI_RUN=cd intbot && DJANGO_SETTINGS_MODULE="intbot.settings" DJANGO_ENV="ci" | |||
|
|
|||
| # Deployment | |||
| DEPLOY_CMD=cd deploy && uvx --from "ansible-core" ansible-playbook -i hosts.yml | |||
| DEPLOY_LINT_CMD=cd deploy && uvx --from "ansible-lint" ansible-lint | |||
There was a problem hiding this comment.
I already commented on that in chat:
Lint should happen before we check-in . Or before we merge the latest.
No description provided.