-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a view to hold the latest variable timestamps #171
Conversation
I've been assuming that these views are a temporary measure to limit how much code we needed to change in one go, and we're aiming to get rid of them. So I'm a bit surprised to see another one added. 👀 I have a few (admittedly vague) concerns about relying on making views like this:
What I might do instead is arrange the data like this on demand in Python code. We could also define a view in the database called something like All that said, I think the definition of this new view looks correct, and in line with the ones we already created, so if you feel it's needed, LGTM. |
Yeah the existing views were added purely for compatibility, though I will say that I would like to keep the
Oh yeah, this will definitely break with multiple versions 😀 I was going to cross that bridge when we get to it. |
I was thinking to also use the timestamps to watch updates on the variable as a whole: we'd ideally like to replot the saved data plot once there are changes on the variable, which can be done by watching timestamps. I don't mind using |
By watching the timestamps, do you mean querying the database for them in a loop? |
Alrighty, I'll close this then. I think Thomas' idea of having a view of only the latest variables is probably the best solution if we still want a simple view to query in the future, that way there's no need to modify the schema. |
Part of #151. Example: