Add support for deleting variables #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
force-pushed
the
delete-variables
branch
from
dab055f
to
f3585d3
Compare
tmichela
reviewed
Jan 29, 2024
damnit/gui/table.py
Outdated
| @@ -44,6 +46,10 @@ def __init__(self) -> None: | |||
| self._columns_widget.itemChanged.connect(self.item_changed) | |||
| self._columns_widget.model().rowsMoved.connect(self.item_moved) | |||
|
|
|||
| self._columns_widget.setContextMenuPolicy(Qt.CustomContextMenu) | |||
| self._columns_widget.customContextMenuRequested.connect(self.show_delete_menu) | |||
| delete_action = QtWidgets.QAction("Delete") | |||
There was a problem hiding this comment.
Suggested change
| delete_action = QtWidgets.QAction("Delete") |
There was a problem hiding this comment.
Oops 🙈 Removed in 82a5e55.
|
Looks good enough to me, since we don't plan to maintain this ui. |
|
Sure, added a comment in 82a5e55. |
|
LGTM |
This is mildly cursed because it will reload the database upon deletion. For two reasons: - There are lingering bugs surrounding moving columns after changing the number of variables, and I don't want to deal with that right now. - Laziness My justification is that deleting a variable is something that will (hopefully) occur rarely, and occur when writing the context file for the first time while the database is likely to be empty-ish.
JamesWrigley
force-pushed
the
delete-variables
branch
from
82a5e55
to
7b38c13
Compare
|
I just realized... what would happen if multiple clients are connected to the same database. The other clients don't know the variable is deleted and may try to access the data. Will it crash? |
|
Oh dear, that is an excellent point 🤦 I'll make another PR to broadcast a deletion message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mildly cursed because it will reload the database upon deletion. For two reasons:
My justification is that deleting a variable is something that will (hopefully) occur rarely, and occur when writing the context file for the first time while the database is likely to be empty-ish (so it won't take an obnoxious amount of time to reload). Plus, loading databases isn't too awful with the v1 format.
Another thing I'm unsure about is the location of the
api.delete_variable()function. I put it inapi.pybecause I have vague ideas about having a writable wrapper for a future read-only API (exposed to users through a separate package), but I couldn't think of a nice way to fit that into theVariableData/RunVariablesclasses. I also considered merging it withDamnitDB.delete_variable()but thenDamnitDBwould come to mean 'database and HDF5 files' while it's currently just 'database'. Not sure how I feel about that.Demo:
Fixes #69.