Allow setting default arguments for dependencies #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Jul 7, 2023
damnit/ctxsupport/ctxrunner.py
Outdated
| for name in ctx_file.ordered_vars(): | ||
| var = ctx_file.vars[name] | ||
|
|
||
| try: | ||
| # Add all variable dependencies | ||
| kwargs = { arg_name: res.get(dep_name) | ||
| kwargs = { arg_name: get_dep_or_default(var, arg_name, dep_name) | ||
| for arg_name, dep_name in var.arg_dependencies().items() } | ||
|
|
||
| # If any are None, skip this variable since we're missing a dependency |
There was a problem hiding this comment.
Suggested change
| # If any are None, skip this variable since we're missing a dependency | |
| # Check for missing dependencies with no default value in the function |
Since we're no longer looking for None. 🙂
There was a problem hiding this comment.
Hah, indeed :) Fixed in 6085018.
|
Other than that comment fix, LGTM |
JamesWrigley
force-pushed
the
dependencies
branch
from
0d8fd38
to
6085018
Compare
JamesWrigley
force-pushed
the
dependencies
branch
from
6085018
to
f91fa0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry-picked from one of my giant branches)