Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the Status column #324

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Hide the Status column #324

merged 1 commit into from
Sep 11, 2024

Conversation

tmichela
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (c295f8d) to head (8242c80).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   74.81%   74.77%   -0.05%     
==========================================
  Files          32       32              
  Lines        4892     4888       -4     
==========================================
- Hits         3660     3655       -5     
- Misses       1232     1233       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takluyver
Copy link
Member

I think 'Status' can now also be removed from here:

DAMNIT/damnit/gui/table.py

Lines 177 to 179 in 88d2e75

for column, status, position in zip(columns, statuses, positions):
if column in ["Status", "comment_id"]:
continue

Other than that, LGTM - I assume you've done some manual testing to see that nothing is obviously completely broken in the GUI.

@takluyver takluyver added the GUI For GUI-related things label Aug 30, 2024
hiding status column
@tmichela tmichela merged commit cc55704 into master Sep 11, 2024
6 checks passed
@tmichela tmichela deleted the hide-status branch September 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI For GUI-related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants