Swap the plotting widgets axis order so they make sense #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make this more explicit, i.e. 'X: Run, Y: Photon energy'? Just swapping them round seems likely to confuse everyone who's used to the current UI, and I don't know if everyone knows the 'Y vs X' convention (e.g. if your first language is not English). |
Explicit is better than implicit :) |
|
LGTM, but I agree with @takluyver comment |
|
Good point, added in 60b7175: |
|
LGTM |
Now it's Y vs X instead of X vs Y.
JamesWrigley
force-pushed
the
axis-order
branch
from
60b7175
to
ea8b7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's Y vs X instead of X vs Y, which confused a couple of people before.
(CC @daviddoji)