Skip to content

- Added the public function "editActiveCell" #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckosmowski wants to merge 2 commits into
base: master
Choose a base branch
from
Open

- Added the public function "editActiveCell" #160

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4619c07
- Added the public function "editActiveCell" to make it possible to t…
Dec 9, 2014
4d220ef
Added a better description for editor parameters
ckosmowski Dec 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/doby-grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3494,6 +3494,16 @@ var DobyGrid = function (options) {
}
};

/**
* Edit the currently active cell (if the table, the column, and the item is editable)
* @method editActiveCell
* @memberof DobyGrid
*
* @param {function} editor - Editor factory to use

@EvHaus EvHaus Dec 16, 2014

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind changing this line to:

@param {function} [editor] - Editor factory to use. By default will use global editor.

To signify that the editor param is optional?

Additionally, we should make the same change to the makeActiveCellEditable header as well.

*/
this.editActiveCell = function (editor) {
makeActiveCellEditable(editor);
};

/**
* Given a set of columns, make sure 'minWidth <= width <= maxWidth
Expand Down