fix(CI): GitHub deprecated v1 use docker compose instead of docker-compose #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m, e.g., docker-compose build to docker compose build (remove the dash)
SamuelLarkin
commented
Nov 19, 2024
| CURRENT_UID=$(id -u):$(id -g) docker-compose --project-name "common-voice" -f "docker-compose.yaml" build web | ||
| docker tag common-voice_web:latest $REGISTRY/$REPOSITORY:$IMAGE_TAG | ||
| CURRENT_UID=$(id -u):$(id -g) docker compose --project-name "common-voice" -f "docker-compose.yaml" build web | ||
| docker image ls |
There was a problem hiding this comment.
Needed to find the new image's name.
SamuelLarkin
commented
Nov 19, 2024
| docker tag common-voice_web:latest $REGISTRY/$REPOSITORY:$IMAGE_TAG | ||
| CURRENT_UID=$(id -u):$(id -g) docker compose --project-name "common-voice" -f "docker-compose.yaml" build web | ||
| docker image ls | ||
| docker tag common-voice-web:latest $REGISTRY/$REPOSITORY:$IMAGE_TAG |
There was a problem hiding this comment.
-web instead of _web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our PAT had expired and after updating it, the workflow was failing on
docker-compose.docker-composeis deprecated since around 2024-04-01 in github workflowsversionis obsolete and generated an unnecessary warning.docker composegenerates a slightly different image name.