Solution includes below changes : #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 10, 2022 21:17
1.As the code is written in Java, C# folders are removed. 2.Added git ignore file 3.Added Junit jars to classpath for Unit testing. 4.changed the package structure. 5.Optimized the toll calculator service to return 60 if the max toll fee exceeds 60 without further calculation. 6.Added the junit test cases to cover business requirements. Future scope: 1.Application can be converted into Rest services with maven as build tool. 2.Application can be deployed to docker by creating docker image file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes below changes,
Future scope: