Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import v2 #4

Merged
merged 326 commits into from
Mar 24, 2024
Merged

Import v2 #4

merged 326 commits into from
Mar 24, 2024

Conversation

keianhzo
Copy link

@keianhzo keianhzo commented Nov 7, 2022

This PR addresses the following issues:

keianhzo and others added 30 commits October 28, 2022 18:06
Limit text versions to LTS
Make sure all tests use latest release (0.0.15) and first supported LTS (2.93.9)
…al cases are handled. Reduce code duplication.
@Exairnous Exairnous merged commit ed6df81 into Exairnous:import Mar 24, 2024
1 check failed
@keianhzo
Copy link
Author

Other than the tests there seem to still be some conflicts here: Hubs-Foundation#63 Do you want to fix them here? Otherwise we can manually resolve them in the main repo.

@Exairnous
Copy link
Owner

We discussed this at the add-on meeting, but I'll post my reply here for the record as well.

Yes, I want to fix them in the import branch. I've merged in your changes, but now since so much time has gone by I need to merge the import branch with the latest from the master branch, then I need to revert the reflection probe changes and do some final updates for features/polishing. I will push updates to the import branch as I do this so that the code is accessible to anyone who wants it.

@Exairnous Exairnous mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants