Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Exif 3.0 tags #2661

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Add new Exif 3.0 tags #2661

merged 1 commit into from
Jun 22, 2023

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jun 22, 2023

Partly addresses #2659

@ghost
Copy link

ghost commented Jun 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kmilos kmilos force-pushed the exif30_tags_add branch from b454d97 to 22d6620 Compare June 22, 2023 10:14
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2661 (22d6620) into 0.28.x (414bff1) will not change coverage.
The diff coverage is 55.88%.

@@           Coverage Diff           @@
##           0.28.x    #2661   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files         103      103           
  Lines       22306    22306           
  Branches    10796    10795    -1     
=======================================
  Hits        14259    14259           
+ Misses       5827     5826    -1     
- Partials     2220     2221    +1     
Impacted Files Coverage Δ
include/exiv2/image.hpp 100.00% <ø> (ø)
include/exiv2/matroskavideo.hpp 60.00% <ø> (ø)
include/exiv2/value.hpp 85.11% <ø> (ø)
src/basicio.cpp 50.52% <0.00%> (ø)
src/canonmn_int.cpp 72.88% <ø> (ø)
src/panasonicmn_int.cpp 52.58% <ø> (ø)
src/quicktimevideo.cpp 60.14% <0.00%> (ø)
src/rafimage.cpp 20.29% <ø> (ø)
src/riffvideo.cpp 62.18% <ø> (ø)
src/tags_int.cpp 79.47% <ø> (ø)
... and 7 more

@kmilos kmilos added the enhancement feature / functionality enhancements label Jun 22, 2023
@kmilos kmilos merged commit eb303ae into 0.28.x Jun 22, 2023
@mergify mergify bot deleted the exif30_tags_add branch June 22, 2023 20:54
@kmilos kmilos added the forward-to-main Forward changes in a 0.28.x PR to main with Mergify label Jun 22, 2023
@kevinbackhouse kevinbackhouse added this to the v0.28.1 milestone Nov 4, 2023
@kmilos kmilos mentioned this pull request Nov 19, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements forward-to-main Forward changes in a 0.28.x PR to main with Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants