-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to allow all exiv2 tags as placeholders #2791
base: main
Are you sure you want to change the base?
Conversation
When replacing characters, which are invalid in file names, it is currently only distinguished between Windows and others. I tried to separate Mac OS and Linux/Unix as well, but I am not sure how to do it. In XMP_environment.h I found a line of code, but it was commented with |
Codecov Report
@@ Coverage Diff @@
## main #2791 +/- ##
==========================================
+ Coverage 63.96% 64.07% +0.10%
==========================================
Files 103 103
Lines 22344 22363 +19
Branches 10835 10851 +16
==========================================
+ Hits 14293 14328 +35
+ Misses 5828 5813 -15
+ Partials 2223 2222 -1
|
This pull request is waiting for approving review since 6 months. Are there reasons not to approve this request or was it just lost out of sight? |
28ad5f8
to
660cfcb
Compare
optimise regex and remove duplicate call of ImageFactory
optimise regex and remove duplicate call of ImageFactory
tests adjusted for msys and cygwin; regex contains "Exif" for better filtering; documentation adjusted
for concatenation of new file name, concatenation operator of std::filesystem::path is not used: On MSYS2 UCRT64 the path separator to be used in terminal is slash, but as concatenation operator a back slash will be added. Rename works but with verbose a path with different operators will be shown.
closes #2238