-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAF: extract more details when printing structure #2824
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2824 +/- ##
==========================================
- Coverage 64.00% 63.89% -0.11%
==========================================
Files 103 103
Lines 22324 22361 +37
Branches 10827 10861 +34
==========================================
Hits 14288 14288
- Misses 5818 5855 +37
Partials 2218 2218
|
Co-authored-by: Kevin Backhouse <[email protected]>
Thanks for all the changes @kevinbackhouse |
kmilos
force-pushed
the
kmilos/raf_printstruct
branch
from
November 13, 2023 13:44
60cc144
to
3536e0d
Compare
kevinbackhouse
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going by https://libopenraw.freedesktop.org/formats/raf/ some bytes after the first meta and CFA offset and length were unknown. @hfiguiere
However, I think these are to describe the file layout when the RAF has two sub-images (like the ones from EXR sensors), so I posit it is a specification of some interleaving scheme w/ skip? (haven't seen anything other than 0), chunk size, and stride....
For the FinePix F700 sample from RPU, this now outputs:
Note how the offset of the 2nd CFA data payload is one CFA chunk size of 2944 after the 1st one, giving the hint about interleaved chunks.
NB: "CFA length" seems to be the effective one, after deinterleaving.