tests: fix parsing w/ path containing "-pa" or "-pS" #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OutputTagExtract test case for tiff_test runs exiv2 two times, with "-pa" and "-pS", and parses their outputs. To know which output to parse, it checks for "-pa" and "-pS" in the string of the command being run; considering that the command string contains the full path to the test data, which is a subdirectory of the sources, this means that a wrong parser will be used in case the full source path contains any of "-pa" or "-pS" (e.g. "/build/some-path/exiv2/..."). Cheap fix for this: since "-pa"/"-pS" are options in the command string, check for them using spaces around.
Codecov Report
@@ Coverage Diff @@
## main #2826 +/- ##
=======================================
Coverage 64.00% 64.00%
=======================================
Files 103 103
Lines 22324 22324
Branches 10827 10827
=======================================
Hits 14288 14288
Misses 5818 5818
Partials 2218 2218 |
kevinbackhouse
approved these changes
Nov 12, 2023
|
@Mergifyio backport 0.28.x |
✅ Backports have been created
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OutputTagExtracttest case fortiff_testruns exiv2 two times, with-paand-pS, and parses their outputs. To know which output to parse, it checks for-paand-pSin the string of the command being run; considering that the command string contains the full path to the test data, which is a subdirectory of the sources, this means that a wrong parser will be used in case the full source path contains any of-paor-pS(e.g./build/some-path/exiv2/...).Cheap fix for this: since
-pa/-pSare options in the command string, check for them using spaces around.