RAF: get actual sensor dimensions #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
reviewed
Nov 15, 2023
kmilos
force-pushed
the
kmilos/raf_dims
branch
from
873cd1a to
6a9a50a
Compare
kmilos
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
==========================================
- Coverage 63.89% 63.88% -0.01%
==========================================
Files 103 103
Lines 22377 22365 -12
Branches 10871 10863 -8
==========================================
- Hits 14297 14288 -9
- Misses 5858 5859 +1
+ Partials 2222 2218 -4 ☔ View full report in Codecov by Sentry. |
|
rebase I think. |
kmilos
force-pushed
the
kmilos/raf_dims
branch
from
6a9a50a to
34f6b84
Compare
neheb
approved these changes
Nov 24, 2023
|
@Mergifyio backport 0.28.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want the dimensions of the embedded preview for RAF raw files, but sensor (or cropped) dimensions like it is the case for other raw formats, e.g. Panasonic RW2.
Edit: also leave room and hooks for decoding the proprietary RAF metadata structure for older cameras not containing the FujifilmIFD.