Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation for Exif.NikonAf2.AFAreaMode #2835

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

norbertwg
Copy link
Contributor

Texts are taken from Nikon NX Studio.
NX Studio shows sligthly different texts for Exif.NikonAf.AFAreaMode, which is already translated in exiv2, e.g. "Single-point AF" instead of "Single Area (wide) (4)". This could be changed, but as the texts are not misleading I prefer to avoid, that users are irritated by a change.

@ghost
Copy link

ghost commented Nov 16, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9ba894) 63.89% compared to head (f2a28af) 63.89%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2835   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         103      103           
  Lines       22361    22361           
  Branches    10861    10861           
=======================================
  Hits        14288    14288           
  Misses       5855     5855           
  Partials     2218     2218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmilos kmilos merged commit e8326ba into Exiv2:main Nov 16, 2023
59 checks passed
@kmilos
Copy link
Collaborator

kmilos commented Nov 16, 2023

Note that there might be more than one way to translate these: https://exiftool.org/TagNames/Nikon.html#AFInfo2

@norbertwg
Copy link
Contributor Author

@kmilos thanks for your hint, the knowledge visible in https://exiftool.org/TagNames is impressive.
Will consider this and prepare a pull request to incorporate this.

@kmilos kmilos added the makerNote Anything related to one of the various supported MakerNote formats label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
makerNote Anything related to one of the various supported MakerNote formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants