translation for Exif.NikonAf2.AFAreaMode#2835
Merged
kmilos merged 1 commit intoExiv2:mainfrom Nov 16, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 103 103
Lines 22361 22361
Branches 10861 10861
=======================================
Hits 14288 14288
Misses 5855 5855
Partials 2218 2218 ☔ View full report in Codecov by Sentry. |
kmilos
approved these changes
Nov 16, 2023
Collaborator
|
Note that there might be more than one way to translate these: https://exiftool.org/TagNames/Nikon.html#AFInfo2 |
Contributor
Author
|
@kmilos thanks for your hint, the knowledge visible in https://exiftool.org/TagNames is impressive. |
kmilos
added
the
makerNote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Texts are taken from Nikon NX Studio.
NX Studio shows sligthly different texts for Exif.NikonAf.AFAreaMode, which is already translated in exiv2, e.g. "Single-point AF" instead of "Single Area (wide) (4)". This could be changed, but as the texts are not misleading I prefer to avoid, that users are irritated by a change.