some cleanups #3109
Merged
some cleanups #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for a C string. Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
more readable. Signed-off-by: Rosen Penev <[email protected]>
find_if is too heavy to use here. Signed-off-by: Rosen Penev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
==========================================
+ Coverage 64.61% 64.65% +0.03%
==========================================
Files 104 104
Lines 22252 22171 -81
Branches 10923 10854 -69
==========================================
- Hits 14379 14335 -44
+ Misses 5628 5596 -32
+ Partials 2245 2240 -5 ☔ View full report in Codecov by Sentry. |
neheb
force-pushed
the
som
branch
2 times, most recently
from
8f4a329 to
275cb13
Compare
Signed-off-by: Rosen Penev <[email protected]>
kevinbackhouse
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.