Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

another one wide char file API recover #3117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

another one wide char file API recover #3117

wants to merge 3 commits into from

Conversation

w17
Copy link

@w17 w17 commented Jan 13, 2025 •
edited
Loading

It doesn't cover all cases.
Just provides ability to open L"unicode.exif" files.

neheb
neheb reviewed Jan 14, 2025
View reviewed changes
src/basicio.cpp Outdated Show resolved Hide resolved
@neheb
Copy link
Collaborator

neheb commented Jan 14, 2025 •
edited
Loading

I can't say I like C APIs here.

Would

path_ = stringFormat({:s}, wstr);

work here?

edit: nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neheb neheb neheb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w17 @neheb